You are viewing a plain text version of this content. The canonical link for it is here.

Posted to solr-dev@lucene.apache.org by "Mark Miller (JIRA)" <ji...@apache.org> on 2009/05/25 22:54:45 UTC

[jira] Reopened: (SOLR-1012) Change SolrIndexSearcher to use inheritence rather than delegation

     [ https://issues.apache.org/jira/browse/SOLR-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller reopened SOLR-1012:
-------------------------------


I'm about to revert this. Its original conception made sense, but then SolrIndexReader was introduced and this change made it so that the Lucene IndexSearcher was init'd with a regular IndexReader rather than a SolrIndexReader. The new Lucene filter stuff just committed casts to a SolrIndexReader, and so expects the Lucene IndexSearcher to hand it a SolrIndexReader. Thats a pain to accomplish with inheritance, so moving back to delegation. It wasn't much of a win to begin with (minor code elimination), so no use fighting for it.

> Change SolrIndexSearcher to use inheritence rather than delegation
> ------------------------------------------------------------------
>
>                 Key: SOLR-1012
>                 URL: https://issues.apache.org/jira/browse/SOLR-1012
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Trivial
>             Fix For: 1.4
>
>         Attachments: SOLR-1012.patch
>
>
> cleans out some unnecessary delegation methods.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.