[jira] Commented: (MAHOUT-531) MatrixWritable doesn't actually write/read anything

["Sean Owen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAHOUT-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991988#comment-12991988 ] 

Sean Owen commented on MAHOUT-531:
----------------------------------

I'm catching up on old issues and closing them out. Let's see if I have this in order:

* I don't think we should introduce getNumNonZeroElements(). It's not necessarily accurate and gets confusing.

* It would be OK to change how getNumNondefaultElements() works. It's not used (in the project) except by test methods. 

* But I suppose the question is which version is more useful? The current version is in theory more expressive since you can always sum up the non-default elements per row to arrive at the same figure. For that reason I favor leaving it as-is. So I suppose I would rather not do 1 or 2.

That takes us waay back to your original point and patch, which is a good one. The patch ought to be committed in some form.

* Do people agree with my thoughts above?

* If so, Alexander, is it possible to change your patch accordingly?


> MatrixWritable doesn't actually write/read anything
> ---------------------------------------------------
>
>                 Key: MAHOUT-531
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-531
>             Project: Mahout
>          Issue Type: Bug
>          Components: Math
>    Affects Versions: 0.4
>            Reporter: Alexander Hans
>             Fix For: 0.5
>
>         Attachments: MAHOUT-531.patch, MAHOUT-531.patch
>
>
> The write() and readFields() methods of MatrixWritable write/read only the classname, they don't write/read actual data.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira