[GitHub] [calcite] jinxing64 commented on a change in pull request #1680: [CALCITE-3621] Push down sort to DB, SQL of Sort rel contains explicit field name instead of * when sort is not top rel

[GitBox <gi...@apache.org>]

jinxing64 commented on a change in pull request #1680: [CALCITE-3621] Push down sort to DB, SQL of Sort rel contains explicit field name instead of * when sort is not top rel
URL: https://github.com/apache/calcite/pull/1680#discussion_r361402419
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
 ##########
 @@ -634,6 +634,13 @@ public Result visit(Sort e) {
     }
     Result x = visitChild(0, e.getInput());
     Builder builder = x.builder(e, Clause.ORDER_BY);
+    if (builder.select.getSelectList() == null) {
 
 Review comment:
   Hi Danny ~
   I gave the suggestion to keep `select *` when `Sort` is the outmost rel, which I think is much simpler.
   I'm ok if you think that Calcite should expand the select list for `Sort`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services