You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/12 17:37:56 UTC

[GitHub] [beam] pskevin commented on a change in pull request #11999: [BEAM-7163] Correcting godoc for passert.Sum

pskevin commented on a change in pull request #11999:
URL: https://github.com/apache/beam/pull/11999#discussion_r439556128



##########
File path: sdks/go/pkg/beam/testing/passert/sum.go
##########
@@ -22,9 +22,9 @@ import (
 	"github.com/apache/beam/sdks/go/pkg/beam/internal/errors"
 )
 
-// Sum validates that the incoming PCollection<int> is a singleton
-// with the given value. Specialized version of Equals that avoids
-// a lot of machinery for testing.
+// Sum validates that the sum and count of elements in the incoming PCollection<int> is
+// the same as the given sum and count, under coder equality. Specialized version of Equals
+// that avoids a lot of machinery for testing.

Review comment:
       Noted and reflected changes accordingly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org