You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by Alessio Soldano <as...@redhat.com> on 2017/05/26 16:27:40 UTC
commons-lang3
Hi,
I've noticed that on master we don't explicitly set a dependency to
common-lang, we just have commons-lang3 there:
https://github.com/apache/cxf/blob/master/parent/pom.xml#L83
That goes with cxf xjc 3.1.0 actually requiring commons-lang3. Now,
unfortunately, it seems that old commons-lang is still transitively
pulled through velocity 1.7.
What do you think about us trying to upgrade to recently released
velocity 2.0 in master, before releasing 3.2.0, so that we can have only
commons-lang3 dependency ?
Cheers
Alessio
Re: commons-lang3
Posted by Alessio Soldano <as...@redhat.com>.
I've actually just merged the PR, the only 2 failures I got on Jenkins did
not look related.
Cheers
Alessio
On Fri, Aug 4, 2017 at 11:42 PM, Alessio Soldano <as...@redhat.com>
wrote:
> Yes, afaics velocity is only used in tooling.
> Anyway, now 2.0 is released, so I've rebased the PR so that it can be
> possibly merged. If there's any comment / feedback... just tell.
> Cheers
> Alessio
>
> On Wed, Jun 14, 2017 at 6:39 PM, Daniel Kulp <dk...@apache.org> wrote:
>
>>
>> I believe the only use of velocity is in the tooling, right?
>>
>> In any case, I don’t think velocity 2.0 is actually released. I’ve
>> checked their dev list and there have been some votes for various “RC”’s,
>> but no final vote for 2.0 or anything (and no announcements or anything).
>> Thus, it’s definitely not something I’d rely on for us at this point.
>> Maybe file a JIRA with them to get them to finish the release and get the
>> artifacts to central.
>>
>> Dan
>>
>>
>>
>> > On Jun 13, 2017, at 7:30 AM, Alessio Soldano <as...@redhat.com>
>> wrote:
>> >
>> > Il 26/05/2017 20:33, Dennis Kieselhorst ha scritto:
>> >> Hi Alessio!
>> >>
>> >>> What do you think about us trying to upgrade to recently released
>> >>> velocity 2.0 in master, before releasing 3.2.0, so that we can have
>> only
>> >>> commons-lang3 dependency ?
>> >> +1 but it's not published to central yet, is it?
>> > It's not, I've built it from the 2.0 tag locally.
>> >
>> > I've created a jira for this [1] and provided an initial PR [2].
>> > Anybody, please review if you have some time :-)
>> > Thanks
>> > Alessio
>> >
>> > [1] https://issues.apache.org/jira/browse/CXF-7405
>> > [2] https://github.com/apache/cxf/pull/282
>>
>> --
>> Daniel Kulp
>> dkulp@apache.org - http://dankulp.com/blog
>> Talend Community Coder - http://coders.talend.com
>>
>>
>
Re: commons-lang3
Posted by Alessio Soldano <as...@redhat.com>.
Yes, afaics velocity is only used in tooling.
Anyway, now 2.0 is released, so I've rebased the PR so that it can be
possibly merged. If there's any comment / feedback... just tell.
Cheers
Alessio
On Wed, Jun 14, 2017 at 6:39 PM, Daniel Kulp <dk...@apache.org> wrote:
>
> I believe the only use of velocity is in the tooling, right?
>
> In any case, I don’t think velocity 2.0 is actually released. I’ve
> checked their dev list and there have been some votes for various “RC”’s,
> but no final vote for 2.0 or anything (and no announcements or anything).
> Thus, it’s definitely not something I’d rely on for us at this point.
> Maybe file a JIRA with them to get them to finish the release and get the
> artifacts to central.
>
> Dan
>
>
>
> > On Jun 13, 2017, at 7:30 AM, Alessio Soldano <as...@redhat.com>
> wrote:
> >
> > Il 26/05/2017 20:33, Dennis Kieselhorst ha scritto:
> >> Hi Alessio!
> >>
> >>> What do you think about us trying to upgrade to recently released
> >>> velocity 2.0 in master, before releasing 3.2.0, so that we can have
> only
> >>> commons-lang3 dependency ?
> >> +1 but it's not published to central yet, is it?
> > It's not, I've built it from the 2.0 tag locally.
> >
> > I've created a jira for this [1] and provided an initial PR [2].
> > Anybody, please review if you have some time :-)
> > Thanks
> > Alessio
> >
> > [1] https://issues.apache.org/jira/browse/CXF-7405
> > [2] https://github.com/apache/cxf/pull/282
>
> --
> Daniel Kulp
> dkulp@apache.org - http://dankulp.com/blog
> Talend Community Coder - http://coders.talend.com
>
>
Re: commons-lang3
Posted by Daniel Kulp <dk...@apache.org>.
I believe the only use of velocity is in the tooling, right?
In any case, I don’t think velocity 2.0 is actually released. I’ve checked their dev list and there have been some votes for various “RC”’s, but no final vote for 2.0 or anything (and no announcements or anything). Thus, it’s definitely not something I’d rely on for us at this point. Maybe file a JIRA with them to get them to finish the release and get the artifacts to central.
Dan
> On Jun 13, 2017, at 7:30 AM, Alessio Soldano <as...@redhat.com> wrote:
>
> Il 26/05/2017 20:33, Dennis Kieselhorst ha scritto:
>> Hi Alessio!
>>
>>> What do you think about us trying to upgrade to recently released
>>> velocity 2.0 in master, before releasing 3.2.0, so that we can have only
>>> commons-lang3 dependency ?
>> +1 but it's not published to central yet, is it?
> It's not, I've built it from the 2.0 tag locally.
>
> I've created a jira for this [1] and provided an initial PR [2].
> Anybody, please review if you have some time :-)
> Thanks
> Alessio
>
> [1] https://issues.apache.org/jira/browse/CXF-7405
> [2] https://github.com/apache/cxf/pull/282
--
Daniel Kulp
dkulp@apache.org - http://dankulp.com/blog
Talend Community Coder - http://coders.talend.com
Re: commons-lang3
Posted by Alessio Soldano <as...@redhat.com>.
Il 26/05/2017 20:33, Dennis Kieselhorst ha scritto:
> Hi Alessio!
>
>> What do you think about us trying to upgrade to recently released
>> velocity 2.0 in master, before releasing 3.2.0, so that we can have only
>> commons-lang3 dependency ?
> +1 but it's not published to central yet, is it?
It's not, I've built it from the 2.0 tag locally.
I've created a jira for this [1] and provided an initial PR [2].
Anybody, please review if you have some time :-)
Thanks
Alessio
[1] https://issues.apache.org/jira/browse/CXF-7405
[2] https://github.com/apache/cxf/pull/282
Re: commons-lang3
Posted by Dennis Kieselhorst <de...@apache.org>.
Hi Alessio!
> What do you think about us trying to upgrade to recently released
> velocity 2.0 in master, before releasing 3.2.0, so that we can have only
> commons-lang3 dependency ?
+1 but it's not published to central yet, is it?
Regards
Dennis