You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/15 15:33:50 UTC
[GitHub] [shardingsphere] terrymanu opened a new issue, #19252: Split ShardingSphereDataSourceFactoryTest.assertCreateDataSourceWithDatabaseName() to more test cases
terrymanu opened a new issue, #19252:
URL: https://github.com/apache/shardingsphere/issues/19252
ShardingSphereDataSourceFactoryTest.assertCreateDataSourceWithDatabaseName() contains multiple calls of `ShardingSphereDataSourceFactory.createDataSource()`.
It is better to split them into different test cases. Please make one test case just assert one scenario.
The method should be split to:
- [ ] assertCreateDataSourceWithModeConfiguration
- [ ] assertCreateDataSourceWithDatabaseNameAndModeConfiguration
- [ ] assertCreateDataSourceWithAllParametersForMultipleDataSourcesWithDefaultDatabaseName
- [ ] assertCreateDataSourceWithAllParametersForMultipleDataSources
- [ ] assertCreateDataSourceWithAllParametersForSingleDataSourceWithDefaultDatabaseName
- [ ] assertCreateDataSourceWithAllParametersForSingleDataSource
- [ ] assertCreateDataSourceWithDefaultModeConfigurationForMultipleDataSources
- [ ] assertCreateDataSourceWithDatabaseNameAndDefaultModeConfigurationForMultipleDataSources
- [ ] assertCreateDataSourceWithDefaultModeConfigurationForSingleDataSource
- [ ] assertCreateDataSourceWithDatabaseNameAndDefaultModeConfigurationForSingleDataSource
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #19252: Split ShardingSphereDataSourceFactoryTest.assertCreateDataSourceWithDatabaseName() to more test cases
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #19252: Split ShardingSphereDataSourceFactoryTest.assertCreateDataSourceWithDatabaseName() to more test cases
URL: https://github.com/apache/shardingsphere/issues/19252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] SalvadorRomo commented on issue #19252: Split ShardingSphereDataSourceFactoryTest.assertCreateDataSourceWithDatabaseName() to more test cases
Posted by GitBox <gi...@apache.org>.
SalvadorRomo commented on issue #19252:
URL: https://github.com/apache/shardingsphere/issues/19252#issuecomment-1187659811
So Can I start work in it ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] SalvadorRomo commented on issue #19252: Split ShardingSphereDataSourceFactoryTest.assertCreateDataSourceWithDatabaseName() to more test cases
Posted by GitBox <gi...@apache.org>.
SalvadorRomo commented on issue #19252:
URL: https://github.com/apache/shardingsphere/issues/19252#issuecomment-1186380158
Hi!! Can I work on this, I'm a Software Engineer and I'm pretty interested in tis project. Regards!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yx9o commented on issue #19252: Split ShardingSphereDataSourceFactoryTest.assertCreateDataSourceWithDatabaseName() to more test cases
Posted by GitBox <gi...@apache.org>.
yx9o commented on issue #19252:
URL: https://github.com/apache/shardingsphere/issues/19252#issuecomment-1188418697
@SalvadorRomo Welcome, assigned to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] SalvadorRomo commented on issue #19252: Split ShardingSphereDataSourceFactoryTest.assertCreateDataSourceWithDatabaseName() to more test cases
Posted by GitBox <gi...@apache.org>.
SalvadorRomo commented on issue #19252:
URL: https://github.com/apache/shardingsphere/issues/19252#issuecomment-1189480406
thks!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org