Re: [I] Git operations don't perform EOL conversion on text files [netbeans]

["mbien (via GitHub)" <gi...@apache.org>]

mbien commented on issue #8504:
URL: https://github.com/apache/netbeans/issues/8504#issuecomment-2887330052

   `readEnvironment()` turned out to be just a distraction. The configuration of the jgit `Repository` object does already contain the user and system config by default. Its probably a design decision that `FileRepositoryBuilder` doesn't care about settings like `defaultBranch` unless it is explicitly set. Thats why it could create a repo with the wrong default branch even though `getConfig().getBaseConfig()` of the just created repo would have the correct `defaultBranch` properly.
   
   Repo init seems to work as intended as far as I can tell.
   It [unsets the AUTOCRLF](https://github.com/apache/netbeans/blob/master/ide/libs.git/src/org/netbeans/libs/git/jgit/commands/InitRepositoryCommand.java#L69) property explicitly which was probably a workaround for https://bugs.eclipse.org/bugs/show_bug.cgi?id=301775#c14 and is likely no longer needed for current jgit versions. But this shouldn't influence anything if the property is in the user/system config.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists