[GitHub] betodealmeida commented on a change in pull request #5759: Bug: fixing async syntax for python 3.7

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #5759: Bug: fixing async syntax for python 3.7
URL: https://github.com/apache/incubator-superset/pull/5759#discussion_r213470763
 
 

 ##########
 File path: tests/celery_tests.py
 ##########
 @@ -123,14 +123,14 @@ def tearDownClass(cls):
         )
 
     def run_sql(self, db_id, sql, client_id, cta='false', tmp_table='tmp',
-                async='false'):
+                async_='false'):
         self.login()
         resp = self.client.post(
             '/superset/sql_json/',
             data=dict(
                 database_id=db_id,
                 sql=sql,
-                async=async,
+                async_=async_,
 
 Review comment:
   Here we're `POST`ing the data payload into the `sql_json` view, so this should actually be `runAsync=async_`. See: https://github.com/apache/incubator-superset/blob/60ecd72aac85b8faddeeb339f24299224ecbca91/superset/views/core.py#L2375

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org