[GitHub] [airflow] potiuk opened a new pull request #19856: Workaround occasional deadlocks with MSSQL

[GitBox <gi...@apache.org>]

potiuk opened a new pull request #19856:
URL: https://github.com/apache/airflow/pull/19856


   We already have a mechanism to retry operations that could result
   in temporary deadlocks - this have been helpful with handling MySQL
   deadlocks - however similar problems occur occasionally in MSSQL and
   there we get a DBAPIError rather than OperationalError:
   
   `sqlalchemy.exc.DBAPIError: (pyodbc.Error) ('40001', '[40001]
   [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Transaction
   (Process ID 55) was deadlocked on lock resources with another process
   and has been chosen as the deadlock victim. Rerun the transaction.
   (1205) (SQLExecDirectW)');
   
   This PR adds DBAPIError to the list of errors that are handled
   by `run_with_db_retries` to mitigate such occasional deadlocks.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #19856: Workaround occasional deadlocks with MSSQL

[GitBox <gi...@apache.org>]

github-actions[bot] commented on pull request #19856:
URL: https://github.com/apache/airflow/pull/19856#issuecomment-980646781


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #19856: Workaround occasional deadlocks with MSSQL

[GitBox <gi...@apache.org>]

potiuk merged pull request #19856:
URL: https://github.com/apache/airflow/pull/19856


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org