Re: [PR] [SPARK-49634][SQL] Remove the ANSI config suggestion in NUMERIC_VALUE_OUT_OF_RANGE.WITH_SUGGESTION [spark]

["uros-b (via GitHub)" <gi...@apache.org>]

uros-b commented on code in PR #54644:
URL: https://github.com/apache/spark/pull/54644#discussion_r3876415160


##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##########
@@ -1436,6 +1436,24 @@ class QueryExecutionErrorsSuite
       parameters = Map("dataType" -> "PhysicalCalendarIntervalType"))
   }
 
+  test("SPARK-49634: Numeric value out of range") {

Review Comment:
   Seems like this assumes ANSI mode is enabled. Spark’s scheduled non-ANSI build sets SPARK_ANSI_SQL_MODE=false; the cast then returns NULL, so intercept[SparkArithmeticException] fails.
   
   Please wrap the test in withSQLConf(SQLConf.ANSI_ENABLED.key -> "true") or move it to QueryExecutionAnsiErrorsSuite.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org