You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "entvex (via GitHub)" <gi...@apache.org> on 2024/05/31 16:11:02 UTC
[PR] [fix] Fixes Create is mishandling time units (specifically, treating seconds as milliseconds). [pulsar]
entvex opened a new pull request, #22815:
URL: https://github.com/apache/pulsar/pull/22815
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
-->
Fixes #22811
### Motivation
This fix addresses a regression caused by changes in this [pull request](https://github.com/apache/pulsar/pull/21412/files). It’s crucial for users who rely on `bin/pulsar tokens create` for creating JWT tokens.
The versions affected 3.2.0 3.2.1 3.2.2 and 3.2.3
### Modifications
In this fix, I have changed it back to use seconds and added additional tests to prevent similar issues in the future.
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [X] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [X] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] Fixes Create is mishandling time units (specifically, treating seconds as milliseconds). [pulsar]
Posted by "entvex (via GitHub)" <gi...@apache.org>.
entvex commented on PR #22815:
URL: https://github.com/apache/pulsar/pull/22815#issuecomment-2144814759
Thanks, @lhotari 😄
I have changed the tests as you requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][cli] Fix expiration of tokens created with "pulsar tokens create" [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #22815:
URL: https://github.com/apache/pulsar/pull/22815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][cli] Fix expiration of tokens created with "pulsar tokens create" [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #22815:
URL: https://github.com/apache/pulsar/pull/22815#issuecomment-2147835431
backported to branch-3.2 with commit f1c45476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org