You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/04/11 18:14:36 UTC
[kudu-CR] [client-test] fix flakes of flush mode timing tests
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6607
Change subject: [client-test] fix flakes of flush mode timing tests
......................................................................
[client-test] fix flakes of flush mode timing tests
Fix for ClientTest.TestFlushModesCompareOpRates* flakiness. The idea
is to run the scenario multiple times to factor out fluctuations in
multi-tasking run-time environments while collecting stats on timings.
Also, the test scenarios are moved into the category of the slow tests.
Change-Id: Iee2abc59785b83fe116a542a265a61281b2f9741
---
M src/kudu/client/client-test.cc
1 file changed, 50 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/6607/1
--
To view, visit http://gerrit.cloudera.org:8080/6607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee2abc59785b83fe116a542a265a61281b2f9741
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [client-test] fix flakes of flush mode timing tests
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [client-test] fix flakes of flush mode timing tests
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6607/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
Line 2510: enum RowSizeMode {
It's up to personal style, but I like having enums like this be an enum class, and removing the enum name from the variants:
enum class RowSize {
CONSTANT,
RANDOM,
}
Then they can be referred to as RowSize::CONSTANT, etc.
Line 2541: // Run the scenario multiple times to factor out fluctuations of multi-tasking
This is just taking the sum of the times across the 16 runs. Just spitballing, but could we get more stable results by doing a simple statistical test, since we now have multiple samples? Perhaps comparing medians? Maybe something to think about if this remains flaky.
--
To view, visit http://gerrit.cloudera.org:8080/6607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee2abc59785b83fe116a542a265a61281b2f9741
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] [client-test] fix flakes of flush mode timing tests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [client-test] fix flakes of flush mode timing tests
......................................................................
[client-test] fix flakes of flush mode timing tests
Fix for ClientTest.TestFlushModesCompareOpRates* flakiness. The idea
is to run the scenario multiple times to factor out fluctuations in
multi-tasking run-time environments while collecting stats on timings.
Also, the test scenarios are moved into the category of the slow tests.
Change-Id: Iee2abc59785b83fe116a542a265a61281b2f9741
---
M src/kudu/client/client-test.cc
1 file changed, 50 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/6607/2
--
To view, visit http://gerrit.cloudera.org:8080/6607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee2abc59785b83fe116a542a265a61281b2f9741
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [client-test] fix flakes of flush mode timing tests
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [client-test] fix flakes of flush mode timing tests
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6607/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
Line 2541: [] { return rand() % (kBufferSizeBytes / 128); });
> I hope the total sum should be enough (being the simplest metric in such se
SGTM
--
To view, visit http://gerrit.cloudera.org:8080/6607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee2abc59785b83fe116a542a265a61281b2f9741
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] [client-test] fix flakes of flush mode timing tests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [client-test] fix flakes of flush mode timing tests
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6607/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
Line 2510: enum RowSizeMode {
> It's up to personal style, but I like having enums like this be an enum cla
Yup, that looks better.
Line 2541: // Run the scenario multiple times to factor out fluctuations of multi-tasking
> This is just taking the sum of the times across the 16 runs. Just spitball
I hope the total sum should be enough (being the simplest metric in such sense).
Currently timings looks like the following:
afb runtime: ~ 30 ms
afs runtime: ~ 320 ms
Sometimes one of RPC threads stacks somewhere in outbound_call.cc and the result becomes something like 350 ms vs 320 ms.
At least the recent failures of corresponding test looked like that.
--
To view, visit http://gerrit.cloudera.org:8080/6607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee2abc59785b83fe116a542a265a61281b2f9741
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] [client-test] fix flakes of flush mode timing tests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6607
to look at the new patch set (#3).
Change subject: [client-test] fix flakes of flush mode timing tests
......................................................................
[client-test] fix flakes of flush mode timing tests
Fix for ClientTest.TestFlushModesCompareOpRates* flakiness. The idea
is to run the scenario multiple times to factor out fluctuations in
multi-tasking run-time environments while collecting stats on timings.
Also, the test scenarios are moved into the category of the slow tests.
Change-Id: Iee2abc59785b83fe116a542a265a61281b2f9741
---
M src/kudu/client/client-test.cc
1 file changed, 54 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/6607/3
--
To view, visit http://gerrit.cloudera.org:8080/6607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee2abc59785b83fe116a542a265a61281b2f9741
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] [client-test] fix flakes of flush mode timing tests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [client-test] fix flakes of flush mode timing tests
......................................................................
[client-test] fix flakes of flush mode timing tests
Fix for ClientTest.TestFlushModesCompareOpRates* flakiness. The idea
is to run the scenario multiple times to factor out fluctuations in
multi-tasking run-time environments while collecting stats on timings.
Also, the test scenarios are moved into the category of the slow tests.
Change-Id: Iee2abc59785b83fe116a542a265a61281b2f9741
Reviewed-on: http://gerrit.cloudera.org:8080/6607
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/client/client-test.cc
1 file changed, 54 insertions(+), 36 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee2abc59785b83fe116a542a265a61281b2f9741
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot