[GitHub] [incubator-superset] robdiciuccio commented on a change in pull request #8069: [SQL Lab] Async query results serialization with MessagePack and PyArrow

[GitBox <gi...@apache.org>]

robdiciuccio commented on a change in pull request #8069: [SQL Lab] Async query results serialization with MessagePack and PyArrow
URL: https://github.com/apache/incubator-superset/pull/8069#discussion_r315928166
 
 

 ##########
 File path: superset/__init__.py
 ##########
 @@ -214,6 +214,7 @@ def index(self):
 security_manager = appbuilder.sm
 
 results_backend = app.config.get("RESULTS_BACKEND")
+results_backend_use_msgpack = app.config.get("RESULTS_BACKEND_USE_MSGPACK")
 
 Review comment:
   Feature flag feels a bit heavy for this case, since it's a global setting and not needed on the frontend. My main concern about pushing this change without a config flag is the lack of testing with data sources other than Postgres, but I do think we should push that testing forward by perhaps defaulting `RESULTS_BACKEND_USE_MSGPACK = True`, and providing an escape hatch to disable should problems crop up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org