[GitHub] [dubbo] CrazyHZM commented on a change in pull request #9840: Code optimization and fix typo

[GitBox <gi...@apache.org>]

CrazyHZM commented on a change in pull request #9840:
URL: https://github.com/apache/dubbo/pull/9840#discussion_r835773031



##########
File path: dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/BroadcastClusterInvoker.java
##########
@@ -89,12 +89,14 @@ public Result doInvoke(final Invocation invocation, List<Invoker<T>> invokers, L
         }
 
         if (exception != null) {
-            if (failIndex == failThresholdIndex) {
-                logger.debug(
+            if (logger.isDebugEnabled()) {
+                if (failIndex == failThresholdIndex) {

Review comment:
       Adjust the order of the two if judgments, so that the judgment condition of `isDebugEnabled() ` follows `logger.debug()`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org