[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25002: [SPARK-28203][Core][Python] PythonRDD should respect SparkContext's hadoop configuration

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #25002: [SPARK-28203][Core][Python] PythonRDD should respect SparkContext's hadoop configuration
URL: https://github.com/apache/spark/pull/25002#discussion_r299768415
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala
 ##########
 @@ -333,7 +333,7 @@ private[spark] object PythonRDD extends Logging {
       valueConverterClass: String,
       confAsMap: java.util.HashMap[String, String],
       batchSize: Int): JavaRDD[Array[Byte]] = {
-    val conf = PythonHadoopUtil.mapToConf(confAsMap)
+    val conf = getMergedConf(confAsMap, sc.hadoopConfiguration())
 
 Review comment:
   @advancedxy . We need a test case which failed without this PR. Please add a test case to show the validity of your PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org