You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "bkietz (via GitHub)" <gi...@apache.org> on 2023/05/08 21:43:25 UTC

[GitHub] [arrow] bkietz opened a new issue, #35497: [C++] Pin flatbuffers compiler version

bkietz opened a new issue, #35497:
URL: https://github.com/apache/arrow/issues/35497

   ### Describe the bug, including details regarding any error messages, version, and platform.
   
   I ran cpp/build-support/update-flatbuffers.sh and the regenerated headers included new failing static assertions like:
   
   ```
   /home/ben/arrow/cpp/src/generated/Message_generated.h:11:41: error: static assertion failed: Non-compatible flatbuffers version included
      11 | static_assert(FLATBUFFERS_VERSION_MAJOR == 23 &&
   ```
   
   The probable fix is to pin the version of the flatbuffers compiler used in c++. As of https://github.com/google/flatbuffers/pull/7203 the compiler inserts these static assertions which assert the version of the compiler- but our vendored flatbuffers are at [1.12.0](https://github.com/apache/arrow/blob/a9a8626e8342e1145ec1b60ffb50154693b9ef92/cpp/thirdparty/flatbuffers/include/flatbuffers/base.h#L150-L152). conda-forge has that version and after installing it I don't see failing static assertions any more.
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] Pin flatbuffers compiler version [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #35497:
URL: https://github.com/apache/arrow/issues/35497#issuecomment-1753025680

   cc @felipecrv 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] Pin flatbuffers compiler version [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou closed issue #35497: [C++] Pin flatbuffers compiler version
URL: https://github.com/apache/arrow/issues/35497


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on issue #35497: [C++] Pin flatbuffers compiler version

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #35497:
URL: https://github.com/apache/arrow/issues/35497#issuecomment-1561543717

   If we do this, we should first bump our vendored version of flatbuffers to a recent well-known changeset.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org