You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Arwin Arni <ar...@collab.net> on 2010/12/30 07:16:41 UTC

[PATCH] Remove unused parameters in libsvn_wc/update_editor.c:accumulate_last_change()

Hi All,

This patch removes some unused parameters in the function 
accumulate_last_change() inside libsvn_wc/update-editor.c

There were two parameters ( svn_wc__db_t *db, const char *local_abspath 
) that were not being used.

I have removed them and fixed the function calls.

I have attached the patch and the log message. Please review and respond.

Regards,
Arwin Arni

Re: [PATCH] Remove unused parameters in libsvn_wc/update_editor.c:accumulate_last_change()

Posted by Kamesh Jayachandran <ka...@collab.net>.

On 12/30/2010 12:46 PM, Arwin Arni wrote:
> Hi All,
>
> This patch removes some unused parameters in the function 
> accumulate_last_change() inside libsvn_wc/update-editor.c
>
> There were two parameters ( svn_wc__db_t *db, const char 
> *local_abspath ) that were not being used.
>
> I have removed them and fixed the function calls.
>
> I have attached the patch and the log message. Please review and respond.
>
> Regards,
> Arwin Arni
Thanks Arwin. Committed in r1053833.

If we had "-Wextra" to our gcc invocation we could have caught it by the 
compiler!.

With regards
Kamesh Jayachandran