You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <se...@apache.org> on 2017/11/03 00:03:32 UTC
Review Request 63531: Update to Mesos 1.4
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63531/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and Bill Farner.
Repository: aurora
Description
-------
This is a non-breaking update to the latest Mesos version.
The mesos.interface Python package has a requirement on a
newer protobuf version. I applied the same update to Java
for consistency.
* Mesos update instructions: https://mesos.apache.org/documentation/latest/upgrades/
(i.e no feature removed that we currently rely on)
* Mesos 1.3 changelog: https://mesos.apache.org/blog/mesos-1-3-0-released/
* Mesos 1.4 changelog: https://mesos.apache.org/blog/mesos-1-4-0-released/
* Protobuf update of Mesos: https://reviews.apache.org/r/58358
(Zhitao Li says he tested compatibility with Aurora using the old protobufs)
* Protobuf changelog: https://github.com/google/protobuf/blob/3.3.x/CHANGES.txt
Diffs
-----
3rdparty/python/BUILD 4aa837ebd638957d89de8536a845234cf05a07dc
3rdparty/python/requirements.txt 0c04b98e791c5de1985724304f384e8dbade8c19
RELEASE-NOTES.md 5122c49354811bdb53bd5a0febb29c5d8a736b0d
Vagrantfile ac1063028a44c5bd6341cc7ba71408e17496fc95
build-support/packer/build.sh 7b7914c11e376a5f7ba7a5ee69fa0962e9bca379
build.gradle 26051ac9267060606a5a4e05a1ac432c1ff4c79b
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 6594325342363eb9a578fda61626a42019fc7204
src/main/java/org/apache/aurora/scheduler/resources/AcceptedOffer.java 291d5c95916915afc48a7143759e523fccd52feb
Diff: https://reviews.apache.org/r/63531/diff/1/
Testing
-------
I tested the following end to end test scenarios and they worked:
* this patch (Mesos 1.4) in the old vagrant box (against Mesos 1.2)
* this patch (Mesos 1.4) in the new vagrant box (against Mesos 1.4)
* master (Mesos 1.2) in the new vagrant box (against Mesos 1.4)
Thanks,
Stephan Erb
Re: Review Request 63531: Update to Mesos 1.4
Posted by Renan DelValle <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63531/#review190749
-----------------------------------------------------------
Ship it!
Ship It!
- Renan DelValle
On Nov. 2, 2017, 5:03 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63531/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2017, 5:03 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is a non-breaking update to the latest Mesos version.
>
> The mesos.interface Python package has a requirement on a
> newer protobuf version. I applied the same update to Java
> for consistency.
>
> * Mesos update instructions: https://mesos.apache.org/documentation/latest/upgrades/
> (i.e no feature removed that we currently rely on)
> * Mesos 1.3 changelog: https://mesos.apache.org/blog/mesos-1-3-0-released/
> * Mesos 1.4 changelog: https://mesos.apache.org/blog/mesos-1-4-0-released/
> * Protobuf update of Mesos: https://reviews.apache.org/r/58358
> (Zhitao Li says he tested compatibility with Aurora using the old protobufs)
> * Protobuf changelog: https://github.com/google/protobuf/blob/3.3.x/CHANGES.txt
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD 4aa837ebd638957d89de8536a845234cf05a07dc
> 3rdparty/python/requirements.txt 0c04b98e791c5de1985724304f384e8dbade8c19
> RELEASE-NOTES.md 5122c49354811bdb53bd5a0febb29c5d8a736b0d
> Vagrantfile ac1063028a44c5bd6341cc7ba71408e17496fc95
> build-support/packer/build.sh 7b7914c11e376a5f7ba7a5ee69fa0962e9bca379
> build.gradle 26051ac9267060606a5a4e05a1ac432c1ff4c79b
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 6594325342363eb9a578fda61626a42019fc7204
> src/main/java/org/apache/aurora/scheduler/resources/AcceptedOffer.java 291d5c95916915afc48a7143759e523fccd52feb
>
>
> Diff: https://reviews.apache.org/r/63531/diff/1/
>
>
> Testing
> -------
>
> I tested the following end to end test scenarios and they worked:
>
> * this patch (Mesos 1.4) in the old vagrant box (against Mesos 1.2)
> * this patch (Mesos 1.4) in the new vagrant box (against Mesos 1.4)
> * master (Mesos 1.2) in the new vagrant box (against Mesos 1.4)
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 63531: Update to Mesos 1.4
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63531/#review189999
-----------------------------------------------------------
Master (d101655) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 3, 2017, 12:03 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63531/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2017, 12:03 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is a non-breaking update to the latest Mesos version.
>
> The mesos.interface Python package has a requirement on a
> newer protobuf version. I applied the same update to Java
> for consistency.
>
> * Mesos update instructions: https://mesos.apache.org/documentation/latest/upgrades/
> (i.e no feature removed that we currently rely on)
> * Mesos 1.3 changelog: https://mesos.apache.org/blog/mesos-1-3-0-released/
> * Mesos 1.4 changelog: https://mesos.apache.org/blog/mesos-1-4-0-released/
> * Protobuf update of Mesos: https://reviews.apache.org/r/58358
> (Zhitao Li says he tested compatibility with Aurora using the old protobufs)
> * Protobuf changelog: https://github.com/google/protobuf/blob/3.3.x/CHANGES.txt
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD 4aa837ebd638957d89de8536a845234cf05a07dc
> 3rdparty/python/requirements.txt 0c04b98e791c5de1985724304f384e8dbade8c19
> RELEASE-NOTES.md 5122c49354811bdb53bd5a0febb29c5d8a736b0d
> Vagrantfile ac1063028a44c5bd6341cc7ba71408e17496fc95
> build-support/packer/build.sh 7b7914c11e376a5f7ba7a5ee69fa0962e9bca379
> build.gradle 26051ac9267060606a5a4e05a1ac432c1ff4c79b
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 6594325342363eb9a578fda61626a42019fc7204
> src/main/java/org/apache/aurora/scheduler/resources/AcceptedOffer.java 291d5c95916915afc48a7143759e523fccd52feb
>
>
> Diff: https://reviews.apache.org/r/63531/diff/1/
>
>
> Testing
> -------
>
> I tested the following end to end test scenarios and they worked:
>
> * this patch (Mesos 1.4) in the old vagrant box (against Mesos 1.2)
> * this patch (Mesos 1.4) in the new vagrant box (against Mesos 1.4)
> * master (Mesos 1.2) in the new vagrant box (against Mesos 1.4)
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 63531: Update to Mesos 1.4
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63531/#review190599
-----------------------------------------------------------
Ship it!
Apologies for losing track of this! Now that 0.19.0 rc0 has been cut, the `CHANGELOG` needs an update in this patch. If we go to rc1, i think we should pull this change in.
- Bill Farner
On Nov. 2, 2017, 5:03 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63531/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2017, 5:03 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is a non-breaking update to the latest Mesos version.
>
> The mesos.interface Python package has a requirement on a
> newer protobuf version. I applied the same update to Java
> for consistency.
>
> * Mesos update instructions: https://mesos.apache.org/documentation/latest/upgrades/
> (i.e no feature removed that we currently rely on)
> * Mesos 1.3 changelog: https://mesos.apache.org/blog/mesos-1-3-0-released/
> * Mesos 1.4 changelog: https://mesos.apache.org/blog/mesos-1-4-0-released/
> * Protobuf update of Mesos: https://reviews.apache.org/r/58358
> (Zhitao Li says he tested compatibility with Aurora using the old protobufs)
> * Protobuf changelog: https://github.com/google/protobuf/blob/3.3.x/CHANGES.txt
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD 4aa837ebd638957d89de8536a845234cf05a07dc
> 3rdparty/python/requirements.txt 0c04b98e791c5de1985724304f384e8dbade8c19
> RELEASE-NOTES.md 5122c49354811bdb53bd5a0febb29c5d8a736b0d
> Vagrantfile ac1063028a44c5bd6341cc7ba71408e17496fc95
> build-support/packer/build.sh 7b7914c11e376a5f7ba7a5ee69fa0962e9bca379
> build.gradle 26051ac9267060606a5a4e05a1ac432c1ff4c79b
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 6594325342363eb9a578fda61626a42019fc7204
> src/main/java/org/apache/aurora/scheduler/resources/AcceptedOffer.java 291d5c95916915afc48a7143759e523fccd52feb
>
>
> Diff: https://reviews.apache.org/r/63531/diff/1/
>
>
> Testing
> -------
>
> I tested the following end to end test scenarios and they worked:
>
> * this patch (Mesos 1.4) in the old vagrant box (against Mesos 1.2)
> * this patch (Mesos 1.4) in the new vagrant box (against Mesos 1.4)
> * master (Mesos 1.2) in the new vagrant box (against Mesos 1.4)
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 63531: Update to Mesos 1.4
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63531/#review190796
-----------------------------------------------------------
Master (9b9b2ee) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 12, 2017, 8:12 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63531/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2017, 8:12 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is a non-breaking update to the latest Mesos version.
>
> The mesos.interface Python package has a requirement on a
> newer protobuf version. I applied the same update to Java
> for consistency.
>
> * Mesos update instructions: https://mesos.apache.org/documentation/latest/upgrades/
> (i.e no feature removed that we currently rely on)
> * Mesos 1.3 changelog: https://mesos.apache.org/blog/mesos-1-3-0-released/
> * Mesos 1.4 changelog: https://mesos.apache.org/blog/mesos-1-4-0-released/
> * Protobuf update of Mesos: https://reviews.apache.org/r/58358
> (Zhitao Li says he tested compatibility with Aurora using the old protobufs)
> * Protobuf changelog: https://github.com/google/protobuf/blob/3.3.x/CHANGES.txt
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD 4aa837ebd638957d89de8536a845234cf05a07dc
> 3rdparty/python/requirements.txt 0c04b98e791c5de1985724304f384e8dbade8c19
> RELEASE-NOTES.md 1a3cbecfea01b4018dcbc99681508b9f3e58667d
> Vagrantfile ac1063028a44c5bd6341cc7ba71408e17496fc95
> build-support/packer/build.sh 7b7914c11e376a5f7ba7a5ee69fa0962e9bca379
> build.gradle ddf153d7174dd0fb62f335fbc2bb2462263c553d
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 6594325342363eb9a578fda61626a42019fc7204
> src/main/java/org/apache/aurora/scheduler/resources/AcceptedOffer.java e8ea3f20e946d7a20bfda2da1899563bddfcd74b
>
>
> Diff: https://reviews.apache.org/r/63531/diff/2/
>
>
> Testing
> -------
>
> I tested the following end to end test scenarios and they worked:
>
> * this patch (Mesos 1.4) in the old vagrant box (against Mesos 1.2)
> * this patch (Mesos 1.4) in the new vagrant box (against Mesos 1.4)
> * master (Mesos 1.2) in the new vagrant box (against Mesos 1.4)
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 63531: Update to Mesos 1.4
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63531/
-----------------------------------------------------------
(Updated Nov. 12, 2017, 9:12 p.m.)
Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and Bill Farner.
Changes
-------
rebase
Repository: aurora
Description
-------
This is a non-breaking update to the latest Mesos version.
The mesos.interface Python package has a requirement on a
newer protobuf version. I applied the same update to Java
for consistency.
* Mesos update instructions: https://mesos.apache.org/documentation/latest/upgrades/
(i.e no feature removed that we currently rely on)
* Mesos 1.3 changelog: https://mesos.apache.org/blog/mesos-1-3-0-released/
* Mesos 1.4 changelog: https://mesos.apache.org/blog/mesos-1-4-0-released/
* Protobuf update of Mesos: https://reviews.apache.org/r/58358
(Zhitao Li says he tested compatibility with Aurora using the old protobufs)
* Protobuf changelog: https://github.com/google/protobuf/blob/3.3.x/CHANGES.txt
Diffs (updated)
-----
3rdparty/python/BUILD 4aa837ebd638957d89de8536a845234cf05a07dc
3rdparty/python/requirements.txt 0c04b98e791c5de1985724304f384e8dbade8c19
RELEASE-NOTES.md 1a3cbecfea01b4018dcbc99681508b9f3e58667d
Vagrantfile ac1063028a44c5bd6341cc7ba71408e17496fc95
build-support/packer/build.sh 7b7914c11e376a5f7ba7a5ee69fa0962e9bca379
build.gradle ddf153d7174dd0fb62f335fbc2bb2462263c553d
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 6594325342363eb9a578fda61626a42019fc7204
src/main/java/org/apache/aurora/scheduler/resources/AcceptedOffer.java e8ea3f20e946d7a20bfda2da1899563bddfcd74b
Diff: https://reviews.apache.org/r/63531/diff/2/
Changes: https://reviews.apache.org/r/63531/diff/1-2/
Testing
-------
I tested the following end to end test scenarios and they worked:
* this patch (Mesos 1.4) in the old vagrant box (against Mesos 1.2)
* this patch (Mesos 1.4) in the new vagrant box (against Mesos 1.4)
* master (Mesos 1.2) in the new vagrant box (against Mesos 1.4)
Thanks,
Stephan Erb