You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/09 18:05:06 UTC
[GitHub] [tvm] junrushao commented on a diff in pull request #12948: [MetaSchedule] Add JSON Database Validation Scripts
junrushao commented on code in PR #12948:
URL: https://github.com/apache/tvm/pull/12948#discussion_r1018260802
##########
python/tvm/meta_schedule/testing/custom_builder_runner.py:
##########
@@ -143,7 +143,7 @@ def run_module_via_rpc(
rpc_config: "RPCConfig",
lib: Union["Module", "Executable"],
dev_type: str,
- args: Dict[str, "np.ndarray"],
+ args: Dict[Any, "np.ndarray"],
Review Comment:
```suggestion
args: Dict[Union[int, str], "np.ndarray"],
```
##########
python/tvm/meta_schedule/testing/custom_builder_runner.py:
##########
@@ -17,7 +17,7 @@
"""Customized builder and runner methods"""
# pylint: disable=import-outside-toplevel
-from typing import TYPE_CHECKING, Callable, Dict, List, Optional, Union
+from typing import TYPE_CHECKING, Dict, List, Any, Optional, Union, Callable
Review Comment:
remove `Callable`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org