You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/02/29 08:08:55 UTC

[GitHub] [zeppelin] zjffdu opened a new pull request #3668: [ZEPPELIN-4635]. Save note permission info into notebook-authorization.json

zjffdu opened a new pull request #3668: [ZEPPELIN-4635]. Save note permission info into notebook-authorization.json
URL: https://github.com/apache/zeppelin/pull/3668
 
 
   ### What is this PR for?
   
   This PR is to revert the changes of ZEPPELIN-3985. Because it would cause the issue of ZEPPELIN-4612. Zeppelin would still save note permission info into `notebook-authorization.json`. But I also do some code refactoring, and we could store the permission info into other storage such as database. Because storing them into one file also has potential issue. such as scale issue, now each time we have to write all notes' permission info into file instead of in the note level.  
   
   
   ### What type of PR is it?
   [Bug Fix | Refactoring]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-4635
   
   ### How should this be tested?
   * CI pass
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? NO
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] asfgit closed pull request #3668: [ZEPPELIN-4635]. Save note permission info into notebook-authorization.json

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3668: [ZEPPELIN-4635]. Save note permission info into notebook-authorization.json
URL: https://github.com/apache/zeppelin/pull/3668
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] Leemoonsoo commented on issue #3668: [ZEPPELIN-4635]. Save note permission info into notebook-authorization.json

Posted by GitBox <gi...@apache.org>.
Leemoonsoo commented on issue #3668: [ZEPPELIN-4635]. Save note permission info into notebook-authorization.json
URL: https://github.com/apache/zeppelin/pull/3668#issuecomment-595921226
 
 
   Thanks @zjffdu LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on issue #3668: [ZEPPELIN-4635]. Save note permission info into notebook-authorization.json

Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3668: [ZEPPELIN-4635]. Save note permission info into notebook-authorization.json
URL: https://github.com/apache/zeppelin/pull/3668#issuecomment-595676551
 
 
   @Leemoonsoo You might want to know this change. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on issue #3668: [ZEPPELIN-4635]. Save note permission info into notebook-authorization.json

Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3668: [ZEPPELIN-4635]. Save note permission info into notebook-authorization.json
URL: https://github.com/apache/zeppelin/pull/3668#issuecomment-596165258
 
 
   Thanks @Leemoonsoo will merge if no more comments

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services