You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by GitBox <gi...@apache.org> on 2022/02/24 07:56:44 UTC
[GitHub] [jclouds] SATYANAN-ANAND opened a new pull request #134: JCLOUDS-1598: Support Metric Alert Operation
SATYANAN-ANAND opened a new pull request #134:
URL: https://github.com/apache/jclouds/pull/134
Please find this PR for Metric Alert operations:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jclouds] SATYANAN-ANAND commented on pull request #134: JCLOUDS-1598: Support Metric Alert Operation
Posted by GitBox <gi...@apache.org>.
SATYANAN-ANAND commented on pull request #134:
URL: https://github.com/apache/jclouds/pull/134#issuecomment-1050607766
> Thanks, @SATYANAN-ANAND !!
>
> We need the Mock and Live tests to be implemented for the API before we can merge the PR. Could you add those? It would be great if you could also share the output of the live tests one they're added.
>
> Thanks!
Please find the test reports.
[MetricAlertApiLiveTest.pdf](https://github.com/apache/jclouds/files/8139363/MetricAlertApiLiveTest.pdf)
[MetricAlertApiMockTest.pdf](https://github.com/apache/jclouds/files/8139364/MetricAlertApiMockTest.pdf)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #134: JCLOUDS-1598: Support Metric Alert Operation
Posted by GitBox <gi...@apache.org>.
SATYANAN-ANAND commented on a change in pull request #134:
URL: https://github.com/apache/jclouds/pull/134#discussion_r814531400
##########
File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/MetricAlert.java
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.azurecompute.arm.domain;
+
+import java.util.Map;
+
+import org.jclouds.javax.annotation.Nullable;
+import org.jclouds.json.SerializedNames;
+
+import com.google.auto.value.AutoValue;
+import com.google.common.collect.ImmutableMap;
+
+@AutoValue
+public abstract class MetricAlert {
+
+ /**
+ * The id of the resource
+ */
+ public abstract String id();
+
+ /**
+ * The name of the resource
+ */
+ public abstract String name();
+
+ /**
+ * The location of the location
+ */
+ public abstract String location();
+
+ /**
+ * The type of the type
+ */
Review comment:
Sorry! My bad.
I added those files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jclouds] nacx commented on a change in pull request #134: JCLOUDS-1598: Support Metric Alert Operation
Posted by GitBox <gi...@apache.org>.
nacx commented on a change in pull request #134:
URL: https://github.com/apache/jclouds/pull/134#discussion_r814502491
##########
File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/MetricAlert.java
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.azurecompute.arm.domain;
+
+import java.util.Map;
+
+import org.jclouds.javax.annotation.Nullable;
+import org.jclouds.json.SerializedNames;
+
+import com.google.auto.value.AutoValue;
+import com.google.common.collect.ImmutableMap;
+
+@AutoValue
+public abstract class MetricAlert {
+
+ /**
+ * The id of the resource
+ */
+ public abstract String id();
+
+ /**
+ * The name of the resource
+ */
+ public abstract String name();
+
+ /**
+ * The location of the location
+ */
+ public abstract String location();
+
+ /**
+ * The type of the type
+ */
Review comment:
Looks like the mock/live tests are not yet pushed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jclouds] nacx commented on a change in pull request #134: JCLOUDS-1598: Support Metric Alert Operation
Posted by GitBox <gi...@apache.org>.
nacx commented on a change in pull request #134:
URL: https://github.com/apache/jclouds/pull/134#discussion_r814082149
##########
File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/MetricAlert.java
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.azurecompute.arm.domain;
+
+import java.util.Map;
+
+import org.jclouds.javax.annotation.Nullable;
+import org.jclouds.json.SerializedNames;
+
+import com.google.auto.value.AutoValue;
+import com.google.common.collect.ImmutableMap;
+
+@AutoValue
+public abstract class MetricAlert {
+
+ /**
+ * The id of the resource
+ */
+ public abstract String id();
+
+ /**
+ * The name of the resource
+ */
+ public abstract String name();
+
+ /**
+ * The location of the location
+ */
+ public abstract String location();
+
+ /**
+ * The type of the type
+ */
Review comment:
Fix these comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #134: JCLOUDS-1598: Support Metric Alert Operation
Posted by GitBox <gi...@apache.org>.
SATYANAN-ANAND commented on a change in pull request #134:
URL: https://github.com/apache/jclouds/pull/134#discussion_r814497649
##########
File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/MetricAlert.java
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.azurecompute.arm.domain;
+
+import java.util.Map;
+
+import org.jclouds.javax.annotation.Nullable;
+import org.jclouds.json.SerializedNames;
+
+import com.google.auto.value.AutoValue;
+import com.google.common.collect.ImmutableMap;
+
+@AutoValue
+public abstract class MetricAlert {
+
+ /**
+ * The id of the resource
+ */
+ public abstract String id();
+
+ /**
+ * The name of the resource
+ */
+ public abstract String name();
+
+ /**
+ * The location of the location
+ */
+ public abstract String location();
+
+ /**
+ * The type of the type
+ */
Review comment:
Hi,
I have updated the javadoc and already added the MetricAlertApiMockTest.java and MetricAlertApiLiveTest.js in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jclouds] nacx merged pull request #134: JCLOUDS-1598: Support Metric Alert Operation
Posted by GitBox <gi...@apache.org>.
nacx merged pull request #134:
URL: https://github.com/apache/jclouds/pull/134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org