[GitHub] [incubator-nuttx] acassis commented on pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

[GitBox <gi...@apache.org>]

acassis commented on pull request #1233:
URL: https://github.com/apache/incubator-nuttx/pull/1233#issuecomment-643850912


   > > @aport Do you have a sample program for testing purposes?
   > 
   > Unfortunately I don't have anything suitable for contribution at the moment. The software I was using to communicate with the modem was proprietary and ported from a Linux platform. I can ask about splitting the MBIM-specific code out and licensing Apache. Should have no issue with that since we decided to use QMI instead of MBIM (of course after I spent all the time writing the MBIM code)
   > 
   > And as you have noticed there are _a lot_ of coding style violations in the original patch. I apologize for the poor quality but it was essentially a proof of concept that was later abandoned, and I posted it to the mailing list in hopes someone else found it useful to them.
   
   Adam, don't worry, you mostly followed the coding style. I didn't spend much time fixing it. I didn't know about these pitfalls before starting porting it. I hope we eventually get it working on mainline.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org