You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "kezhenxu94 (GitHub)" <gi...@apache.org> on 2019/01/17 12:53:07 UTC

[GitHub] [incubator-dubbo-ops] kezhenxu94 opened pull request #253: Add integreation tests

#216 .

Hi @nzomkxia , this patch sets up integration test environment and creates a integration test `org.apache.dubbo.admin.controller.ServiceControllerTest` for reference, if this method is accetable, I'll add more tests in the following PRs.

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/253 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] lovepoem commented on pull request #253: Add integration tests

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
extract the version property

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/253 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #253: Add integration tests

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=h1) Report
> Merging [#253](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/70b1eb11bf9df1266b027e4900f5ce5b208cd71d?src=pr&el=desc) will **increase** coverage by `8.96%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=tree)

```diff
@@              Coverage Diff              @@
##             develop     #253      +/-   ##
=============================================
+ Coverage       2.74%   11.71%   +8.96%     
- Complexity        48      161     +113     
=============================================
  Files             85       85              
  Lines           3457     3457              
  Branches         547      547              
=============================================
+ Hits              95      405     +310     
+ Misses          3355     3006     -349     
- Partials           7       46      +39
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../dubbo/admin/service/impl/OverrideServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL092ZXJyaWRlU2VydmljZUltcGwuamF2YQ==) | `0.57% <0%> (+0.57%)` | `1% <0%> (+1%)` | :arrow_up: |
| [.../dubbo/admin/service/impl/ConsumerServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL0NvbnN1bWVyU2VydmljZUltcGwuamF2YQ==) | `0.84% <0%> (+0.84%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...che/dubbo/admin/service/impl/RouteServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL1JvdXRlU2VydmljZUltcGwuamF2YQ==) | `0.99% <0%> (+0.99%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...he/dubbo/admin/controller/TagRoutesController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9UYWdSb3V0ZXNDb250cm9sbGVyLmphdmE=) | `8.69% <0%> (+8.69%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...ubbo/admin/service/impl/ManagementServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL01hbmFnZW1lbnRTZXJ2aWNlSW1wbC5qYXZh) | `9.09% <0%> (+9.09%)` | `2% <0%> (+2%)` | :arrow_up: |
| [...he/dubbo/admin/controller/OverridesController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9PdmVycmlkZXNDb250cm9sbGVyLmphdmE=) | `9.75% <0%> (+9.75%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...bo/admin/controller/ConditionRoutesController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9Db25kaXRpb25Sb3V0ZXNDb250cm9sbGVyLmphdmE=) | `9.75% <0%> (+9.75%)` | `1% <0%> (+1%)` | :arrow_up: |
| [.../dubbo/admin/controller/LoadBalanceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9Mb2FkQmFsYW5jZUNvbnRyb2xsZXIuamF2YQ==) | `10.52% <0%> (+10.52%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...pache/dubbo/admin/controller/WeightController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9XZWlnaHRDb250cm9sbGVyLmphdmE=) | `11.11% <0%> (+11.11%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...va/org/apache/dubbo/admin/model/domain/Entity.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZG9tYWluL0VudGl0eS5qYXZh) | `11.76% <0%> (+11.76%)` | `2% <0%> (+2%)` | :arrow_up: |
| ... and [18 more](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=footer). Last update [70b1eb1...aeca37a](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/253 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] kezhenxu94 commented on issue #253: Add integration tests

Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
Can any one of the admins review this patch?

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/253 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] lovepoem commented on issue #253: Add integration tests

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
lgtm

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/253 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] lovepoem closed pull request #253: Add integration tests

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
[ pull request closed by lovepoem ]

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/253 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] lovepoem commented on pull request #253: Add integration tests

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
author 

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/253 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] lovepoem commented on pull request #253: Add integration tests

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
remove author info

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/253 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #253: Add integration tests

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=h1) Report
> Merging [#253](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/70b1eb11bf9df1266b027e4900f5ce5b208cd71d?src=pr&el=desc) will **increase** coverage by `8.96%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=tree)

```diff
@@              Coverage Diff              @@
##             develop     #253      +/-   ##
=============================================
+ Coverage       2.74%   11.71%   +8.96%     
- Complexity        48      161     +113     
=============================================
  Files             85       85              
  Lines           3457     3457              
  Branches         547      547              
=============================================
+ Hits              95      405     +310     
+ Misses          3355     3006     -349     
- Partials           7       46      +39
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../dubbo/admin/service/impl/OverrideServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL092ZXJyaWRlU2VydmljZUltcGwuamF2YQ==) | `0.57% <0%> (+0.57%)` | `1% <0%> (+1%)` | :arrow_up: |
| [.../dubbo/admin/service/impl/ConsumerServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL0NvbnN1bWVyU2VydmljZUltcGwuamF2YQ==) | `0.84% <0%> (+0.84%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...che/dubbo/admin/service/impl/RouteServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL1JvdXRlU2VydmljZUltcGwuamF2YQ==) | `0.99% <0%> (+0.99%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...he/dubbo/admin/controller/TagRoutesController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9UYWdSb3V0ZXNDb250cm9sbGVyLmphdmE=) | `8.69% <0%> (+8.69%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...ubbo/admin/service/impl/ManagementServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL01hbmFnZW1lbnRTZXJ2aWNlSW1wbC5qYXZh) | `9.09% <0%> (+9.09%)` | `2% <0%> (+2%)` | :arrow_up: |
| [...he/dubbo/admin/controller/OverridesController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9PdmVycmlkZXNDb250cm9sbGVyLmphdmE=) | `9.75% <0%> (+9.75%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...bo/admin/controller/ConditionRoutesController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9Db25kaXRpb25Sb3V0ZXNDb250cm9sbGVyLmphdmE=) | `9.75% <0%> (+9.75%)` | `1% <0%> (+1%)` | :arrow_up: |
| [.../dubbo/admin/controller/LoadBalanceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9Mb2FkQmFsYW5jZUNvbnRyb2xsZXIuamF2YQ==) | `10.52% <0%> (+10.52%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...pache/dubbo/admin/controller/WeightController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9XZWlnaHRDb250cm9sbGVyLmphdmE=) | `11.11% <0%> (+11.11%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...va/org/apache/dubbo/admin/model/domain/Entity.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZG9tYWluL0VudGl0eS5qYXZh) | `11.76% <0%> (+11.76%)` | `2% <0%> (+2%)` | :arrow_up: |
| ... and [18 more](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=footer). Last update [70b1eb1...aeca37a](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/253 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] kezhenxu94 commented on pull request #253: Add integration tests

Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
I'll remove this dependency since it is include in the parent `pom.xml`

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/253 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] kezhenxu94 commented on issue #253: Add integration tests

Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
Since following commits to add more tests are bases on this PR, if any changes should be done, please let me know, @nzomkxia @lovepoem 

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/253 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #253: Add integration tests

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=h1) Report
> Merging [#253](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/70b1eb11bf9df1266b027e4900f5ce5b208cd71d?src=pr&el=desc) will **increase** coverage by `8.96%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=tree)

```diff
@@              Coverage Diff              @@
##             develop     #253      +/-   ##
=============================================
+ Coverage       2.74%   11.71%   +8.96%     
- Complexity        48      161     +113     
=============================================
  Files             85       85              
  Lines           3457     3457              
  Branches         547      547              
=============================================
+ Hits              95      405     +310     
+ Misses          3355     3006     -349     
- Partials           7       46      +39
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../dubbo/admin/service/impl/OverrideServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL092ZXJyaWRlU2VydmljZUltcGwuamF2YQ==) | `0.57% <0%> (+0.57%)` | `1% <0%> (+1%)` | :arrow_up: |
| [.../dubbo/admin/service/impl/ConsumerServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL0NvbnN1bWVyU2VydmljZUltcGwuamF2YQ==) | `0.84% <0%> (+0.84%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...che/dubbo/admin/service/impl/RouteServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL1JvdXRlU2VydmljZUltcGwuamF2YQ==) | `0.99% <0%> (+0.99%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...he/dubbo/admin/controller/TagRoutesController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9UYWdSb3V0ZXNDb250cm9sbGVyLmphdmE=) | `8.69% <0%> (+8.69%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...ubbo/admin/service/impl/ManagementServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL01hbmFnZW1lbnRTZXJ2aWNlSW1wbC5qYXZh) | `9.09% <0%> (+9.09%)` | `2% <0%> (+2%)` | :arrow_up: |
| [...he/dubbo/admin/controller/OverridesController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9PdmVycmlkZXNDb250cm9sbGVyLmphdmE=) | `9.75% <0%> (+9.75%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...bo/admin/controller/ConditionRoutesController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9Db25kaXRpb25Sb3V0ZXNDb250cm9sbGVyLmphdmE=) | `9.75% <0%> (+9.75%)` | `1% <0%> (+1%)` | :arrow_up: |
| [.../dubbo/admin/controller/LoadBalanceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9Mb2FkQmFsYW5jZUNvbnRyb2xsZXIuamF2YQ==) | `10.52% <0%> (+10.52%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...pache/dubbo/admin/controller/WeightController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9XZWlnaHRDb250cm9sbGVyLmphdmE=) | `11.11% <0%> (+11.11%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...va/org/apache/dubbo/admin/model/domain/Entity.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZG9tYWluL0VudGl0eS5qYXZh) | `11.76% <0%> (+11.76%)` | `2% <0%> (+2%)` | :arrow_up: |
| ... and [18 more](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=footer). Last update [70b1eb1...a232842](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/253 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #253: Add integration tests

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=h1) Report
> Merging [#253](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/70b1eb11bf9df1266b027e4900f5ce5b208cd71d?src=pr&el=desc) will **increase** coverage by `8.96%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=tree)

```diff
@@              Coverage Diff              @@
##             develop     #253      +/-   ##
=============================================
+ Coverage       2.74%   11.71%   +8.96%     
- Complexity        48      161     +113     
=============================================
  Files             85       85              
  Lines           3457     3457              
  Branches         547      547              
=============================================
+ Hits              95      405     +310     
+ Misses          3355     3006     -349     
- Partials           7       46      +39
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../dubbo/admin/service/impl/OverrideServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL092ZXJyaWRlU2VydmljZUltcGwuamF2YQ==) | `0.57% <0%> (+0.57%)` | `1% <0%> (+1%)` | :arrow_up: |
| [.../dubbo/admin/service/impl/ConsumerServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL0NvbnN1bWVyU2VydmljZUltcGwuamF2YQ==) | `0.84% <0%> (+0.84%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...che/dubbo/admin/service/impl/RouteServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL1JvdXRlU2VydmljZUltcGwuamF2YQ==) | `0.99% <0%> (+0.99%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...he/dubbo/admin/controller/TagRoutesController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9UYWdSb3V0ZXNDb250cm9sbGVyLmphdmE=) | `8.69% <0%> (+8.69%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...ubbo/admin/service/impl/ManagementServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL01hbmFnZW1lbnRTZXJ2aWNlSW1wbC5qYXZh) | `9.09% <0%> (+9.09%)` | `2% <0%> (+2%)` | :arrow_up: |
| [...he/dubbo/admin/controller/OverridesController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9PdmVycmlkZXNDb250cm9sbGVyLmphdmE=) | `9.75% <0%> (+9.75%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...bo/admin/controller/ConditionRoutesController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9Db25kaXRpb25Sb3V0ZXNDb250cm9sbGVyLmphdmE=) | `9.75% <0%> (+9.75%)` | `1% <0%> (+1%)` | :arrow_up: |
| [.../dubbo/admin/controller/LoadBalanceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9Mb2FkQmFsYW5jZUNvbnRyb2xsZXIuamF2YQ==) | `10.52% <0%> (+10.52%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...pache/dubbo/admin/controller/WeightController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9XZWlnaHRDb250cm9sbGVyLmphdmE=) | `11.11% <0%> (+11.11%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...va/org/apache/dubbo/admin/model/domain/Entity.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZG9tYWluL0VudGl0eS5qYXZh) | `11.76% <0%> (+11.76%)` | `2% <0%> (+2%)` | :arrow_up: |
| ... and [18 more](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=footer). Last update [70b1eb1...a232842](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/253?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/253 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] kezhenxu94 commented on pull request #253: Add integration tests

Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
I'll remove this dependency since it is include in the parent `pom.xml`

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/253 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] kezhenxu94 commented on issue #253: Add integration tests

Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
Thanks for reviewing, changes are made as requested

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/253 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org