You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/02 03:19:41 UTC

[GitHub] [airflow] mik-laj opened a new issue #10104: Double check UPDATING.md for "2.0" doesn't include breaking changes in import paths

mik-laj opened a new issue #10104:
URL: https://github.com/apache/airflow/issues/10104


   Hello, 
   
   We should check if all operators and hooks available in Airflow 1.10 are also importable in Airflow 2.0. All these changes should also be included in
   https://github.com/apache/airflow/blob/master/tests/deprecated_classes.py
   
   Technically speaking, we should install Airflow 1.10, generate a list of operators/hooks, and then try to import each of it for Airflow 2.0.
   In order to generate a list of operators, we can use this script:
   https://github.com/apache/airflow/blob/master/scripts/list-integrations.py
   
   Best regards,
   Kamil BreguĊ‚a


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on issue #10104: Double check UPDATING.md for "2.0" doesn't include breaking changes in import paths

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #10104:
URL: https://github.com/apache/airflow/issues/10104#issuecomment-668318509


   @bhavaniravi I assigned you to this ticket.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on issue #10104: Double check UPDATING.md for "2.0" doesn't include breaking changes in import paths

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #10104:
URL: https://github.com/apache/airflow/issues/10104#issuecomment-676837576


   @bhavaniravi We have two deprecation messages. One for the module and one for the classes. 
   <img width="723" alt="Screenshot 2020-08-20 at 03 02 03" src="https://user-images.githubusercontent.com/12058428/90704851-de8ae000-e291-11ea-8464-649794871195.png">
   <img width="906" alt="Screenshot 2020-08-20 at 03 02 22" src="https://user-images.githubusercontent.com/12058428/90704856-e0ed3a00-e291-11ea-97ee-51fabfcdf11e.png">
   When it comes to use it for Python it makes no difference if you import the entire module and use the class referencing, as attributes, or import each class in your modulle.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on issue #10104: Double check UPDATING.md for "2.0" doesn't include breaking changes in import paths

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #10104:
URL: https://github.com/apache/airflow/issues/10104#issuecomment-741875824


   Do we need to anything more here? Is this issue for core operators / AIP-21 ?
   
   https://github.com/apache/airflow/blob/master/UPDATING.md#changes-to-import-paths


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ryw commented on issue #10104: Double check UPDATING.md for "2.0" doesn't include breaking changes in import paths

Posted by GitBox <gi...@apache.org>.
ryw commented on issue #10104:
URL: https://github.com/apache/airflow/issues/10104#issuecomment-736542485


   @bhavaniravi are you still working on this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on issue #10104: Double check UPDATING.md for "2.0" doesn't include breaking changes in import paths

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #10104:
URL: https://github.com/apache/airflow/issues/10104#issuecomment-741877934


   As I was checking, all imports worked.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bhavaniravi commented on issue #10104: Double check UPDATING.md for "2.0" doesn't include breaking changes in import paths

Posted by GitBox <gi...@apache.org>.
bhavaniravi commented on issue #10104:
URL: https://github.com/apache/airflow/issues/10104#issuecomment-676825067


   @mik-laj I have a question 
   
   How does `deprecated_classes` handle backward compatibility when importing modules instead of classes 
   
   Example:
   
   ```
   from airflow.contrib.hooks import gcp_kms_hook"
   ```
   Instead of 
   ```
   from airflow.contrib.hooks.gcp_kms_hook import GoogleCloudKMSHook
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj closed issue #10104: Double check UPDATING.md for "2.0" doesn't include breaking changes in import paths

Posted by GitBox <gi...@apache.org>.
mik-laj closed issue #10104:
URL: https://github.com/apache/airflow/issues/10104


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bhavaniravi commented on issue #10104: Double check UPDATING.md for "2.0" doesn't include breaking changes in import paths

Posted by GitBox <gi...@apache.org>.
bhavaniravi commented on issue #10104:
URL: https://github.com/apache/airflow/issues/10104#issuecomment-668317275


   I would like to take this up, would give me a head start with 2.0


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org