You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Stephen Pain <st...@db.com> on 2004/06/27 21:47:41 UTC

pls patch JMSReceiver!

Hi all,

I'd really appreciate it if someone could apply the small patch below which fixes problems I had when trying to connect to more than one (weblogic) environment but where the topicFactoryName is the same across the environments...

Thanks!

Cheers,
Stephen

Index: JMSReceiver.java
===================================================================
RCS file: /home/cvspublic/logging-log4j/src/java/org/apache/log4j/net/JMSReceiver.java,v
retrieving revision 1.6
diff -u -r1.6 JMSReceiver.java
--- JMSReceiver.java    9 Jun 2004 09:31:33 -0000     1.6
+++ JMSReceiver.java    27 Jun 2004 19:30:00 -0000
@@ -163,7 +163,10 @@
       JMSReceiver receiver = (JMSReceiver)testPlugin;

       // check for same topic name and super class equivalency
+      // also check for jndi path - otherwise connecting to the same
+      // topic factory name on different jms servers causes problems
       return (topicFactoryName.equals(receiver.getTopicFactoryName()) &&
+        (jndiPath == null || jndiPath.equals(receiver.getJndiPath())) &&
         super.isEquivalent(testPlugin));
     }



--

This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.



---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


RE: pls patch JMSReceiver!

Posted by Paul Smith <ps...@aconex.com>.
I've applied the patch to CVS (done by hand, I had bracket trouble due
to lack of coffee this morning).
Cheers,

Paul Smith

> -----Original Message-----
> From: Stephen Pain [mailto:stephen.pain@db.com]
> Sent: Monday, June 28, 2004 5:48 AM
> To: Log4J Developers List
> Subject: pls patch JMSReceiver!
> 
> 
> Hi all,
> 
> I'd really appreciate it if someone could apply the small patch below
> which fixes problems I had when trying to connect to more than one
> (weblogic) environment but where the topicFactoryName is the same across
> the environments...
> 
> Thanks!
> 
> Cheers,
> Stephen
> 
> Index: JMSReceiver.java
> ===================================================================
> RCS file: /home/cvspublic/logging-
> log4j/src/java/org/apache/log4j/net/JMSReceiver.java,v
> retrieving revision 1.6
> diff -u -r1.6 JMSReceiver.java
> --- JMSReceiver.java    9 Jun 2004 09:31:33 -0000     1.6
> +++ JMSReceiver.java    27 Jun 2004 19:30:00 -0000
> @@ -163,7 +163,10 @@
>        JMSReceiver receiver = (JMSReceiver)testPlugin;
> 
>        // check for same topic name and super class equivalency
> +      // also check for jndi path - otherwise connecting to the same
> +      // topic factory name on different jms servers causes problems
>        return (topicFactoryName.equals(receiver.getTopicFactoryName()) &&
> +        (jndiPath == null || jndiPath.equals(receiver.getJndiPath())) &&
>          super.isEquivalent(testPlugin));
>      }
> 
> 
> 
> --
> 
> This e-mail may contain confidential and/or privileged information. If you
> are not the intended recipient (or have received this e-mail in error)
> please notify the sender immediately and destroy this e-mail. Any
> unauthorized copying, disclosure or distribution of the material in this
> e-mail is strictly forbidden.
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org