You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by "Tim Allison (Jira)" <ji...@apache.org> on 2022/02/11 16:28:00 UTC

[jira] [Commented] (TIKA-3679) Enforce readFully and skipFully throughout

    [ https://issues.apache.org/jira/browse/TIKA-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491026#comment-17491026 ] 

Tim Allison commented on TIKA-3679:
-----------------------------------

It looks like POI's IOUtils.readFully and skipFully do not throw an EOF or other IOException if the full number of bytes can't be read/skipped.  However, commons-io's do.  So, we should try to switch to commons-io's where possible.

> Enforce readFully and skipFully throughout
> ------------------------------------------
>
>                 Key: TIKA-3679
>                 URL: https://issues.apache.org/jira/browse/TIKA-3679
>             Project: Tika
>          Issue Type: Task
>            Reporter: Tim Allison
>            Priority: Minor
>
> There are a handful of places in our codebase where we readFully or skipFully without confirming that the correct number of bytes were read.  We used to have to ignore this in our isoparser mp4's parser, but we generally shouldn't ignore a mismatch.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)