[jira] [Commented] (FLINK-8370) Port AbstractAggregatingMetricsHandler to RestServerEndpoint

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423827#comment-16423827 ] 

ASF GitHub Bot commented on FLINK-8370:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5805

    [FLINK-8370][REST] Port AggregatingMetricsHandler to flip6 

    ## What is the purpose of the change
    
    This PR ports the `AggregatingMetricsHandler` classes to flip6.
    
    Additionally this PR contains 2 minor changes:
    * the `MessageParameter` constructor is now `protected`
    * the converter methods of `QueryParameters` may now also throw `ConversionExceptions` like their `PathParamater` counter-part
    
    ## Brief change log
    
    * the `MessageParameter` constructor is now `protected`
    * the converter methods of `QueryParameters` may now also throw `ConversionExceptions` like their `PathParamater` counter-part
    * port `AggregatingMetricsHandler` to flip6
      * duplicate `DoubleAccumulator` class
      * define headers, various parameters and response bodies
      * define handlers
        * conceptually they work like the legacy versions, but I had to beef up the aggregation factories a bit as the existing approach wasn't compatible with an actual constructor
      *  add handlers to WebMonitorEndpoint
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
    * run tests extending `AggregatingMetricsHandlerTestBase`.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (documented (via legacy documentation))


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8370

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5805.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5805
    
----
commit e238b85d12feda1f66de9ebf8aaaeaa223c3129d
Author: zentol <ch...@...>
Date:   2018-03-26T12:41:03Z

    [hotfix][metrics] Make MessageParameter constructor protected

commit 188f5ef96bce2a7fa8ee382ab1d5fc900d078149
Author: zentol <ch...@...>
Date:   2018-03-26T12:41:25Z

    [hotfix][metrics] Allow QueryParameter converters to throw ConversionExceptions

commit 85d00792ca34849034bc7c59a9b7d07ed4fff486
Author: zentol <ch...@...>
Date:   2018-03-28T10:52:07Z

    [FLINK-8370][REST] Port AggregatingMetricsHandler to flip6

----


> Port AbstractAggregatingMetricsHandler to RestServerEndpoint
> ------------------------------------------------------------
>
>                 Key: FLINK-8370
>                 URL: https://issues.apache.org/jira/browse/FLINK-8370
>             Project: Flink
>          Issue Type: Sub-task
>          Components: REST
>    Affects Versions: 1.5.0
>            Reporter: Gary Yao
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> Port subclasses of {{org.apache.flink.runtime.rest.handler.legacy.metrics.AbstractAggregatingMetricsHandler}} to new FLIP-6 {{RestServerEndpoint}}.
> The following handlers need to be migrated:
> * {{AggregatingJobsMetricsHandler}}
> * {{AggregatingSubtasksMetricsHandler}}
> * {{AggregatingTaskManagersMetricsHandler}}
> New handlers should then be registered in {{WebMonitorEndpoint}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)