[GitHub] [arrow-datafusion] izveigor commented on a diff in pull request #5816: feat: add optimization support to LOG and POWER functions

["izveigor (via GitHub)" <gi...@apache.org>]

izveigor commented on code in PR #5816:
URL: https://github.com/apache/arrow-datafusion/pull/5816#discussion_r1155114663


##########
datafusion/common/src/scalar.rs:
##########
@@ -1723,6 +1745,27 @@ impl ScalarValue {
         })
     }
 
+    pub fn new_ten(datatype: &DataType) -> Result<ScalarValue> {

Review Comment:
   Should we create the function `new_int`, that would receive the input integer number (I think i8), and the datatype and return the number with this datatype?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org