You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2014/07/09 22:22:17 UTC
svn commit: r1609288 -
/maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java
Author: michaelo
Date: Wed Jul 9 20:22:17 2014
New Revision: 1609288
URL: http://svn.apache.org/r1609288
Log:
[MCHECKSTYLE-237] Changeset 1608113 introduces "Line 0" regression
Modified:
maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java
Modified: maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java?rev=1609288&r1=1609287&r2=1609288&view=diff
==============================================================================
--- maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java (original)
+++ maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java Wed Jul 9 20:22:17 2014
@@ -730,16 +730,18 @@ public class CheckstyleReportGenerator
sink.tableCell_();
sink.tableCell();
- if ( getXrefLocation() != null )
+
+ int line = event.getLine();
+ if ( getXrefLocation() != null && line != 0 )
{
sink.link( getXrefLocation() + "/" + filename.replaceAll( "\\.java$", ".html" ) + "#L"
- + event.getLine() );
- sink.text( String.valueOf( event.getLine() ) );
+ + line );
+ sink.text( String.valueOf( line ) );
sink.link_();
}
- else
+ else if ( line != 0 )
{
- sink.text( String.valueOf( event.getLine() ) );
+ sink.text( String.valueOf( line ) );
}
sink.tableCell_();