You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "anantaoutlook (via GitHub)" <gi...@apache.org> on 2024/08/13 17:09:34 UTC
[PR] Fixed issue raised in ticket #22979 [superset]
anantaoutlook opened a new pull request, #29932:
URL: https://github.com/apache/superset/pull/29932
Fixed issue raised in ticket https://github.com/apache/superset/issues/22979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Fixed issue raised in ticket #22979 [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #29932:
URL: https://github.com/apache/superset/pull/29932#discussion_r1717309483
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx:
##########
@@ -286,13 +286,67 @@ const FilterValue: FC<FilterControlProps> = ({
],
);
- const filterState = useMemo(
- () => ({
- ...filter.dataMask?.filterState,
+ const filterState = useMemo(() => {
+ const filterStateData = filter.dataMask?.filterState || {};
+ if (formData?.defaultValue?.length > 0) {
+ return {
+ ...filterStateData,
+ validateStatus,
+ validateMessage: '',
+ };
+ }
+ if (filter?.dataMask?.filterState?.selected) {
+ return {
+ ...filterStateData,
+ validateStatus,
+ validateMessage: '',
+ };
+ }
+ if (filter.cascadeParentIds.length <= 0 || !formData.defaultToFirstItem) {
+ return {
+ ...filterStateData,
+ validateStatus,
+ validateMessage: '',
+ selected: false,
+ };
+ }
+ if (state?.length > 0 && formData.defaultToFirstItem) {
+ if (formData.multiSelect) {
Review Comment:
if we're commenting this whole block out, why do we still need to keep the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Fixed issue raised in ticket #22979 [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #29932:
URL: https://github.com/apache/superset/pull/29932#issuecomment-2289404579
@anantaoutlook i see parts where you commented out the code, can we clean those up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Fixed issue raised in ticket #22979 [superset]
Posted by "anantaoutlook (via GitHub)" <gi...@apache.org>.
anantaoutlook commented on PR #29932:
URL: https://github.com/apache/superset/pull/29932#issuecomment-2289444199
> @anantaoutlook i see parts where you commented out the code, can we clean those up?
> Definitely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Fixed issue raised in ticket #22979 [superset]
Posted by "anantaoutlook (via GitHub)" <gi...@apache.org>.
anantaoutlook closed pull request #29932: Fixed issue raised in ticket #22979
URL: https://github.com/apache/superset/pull/29932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Fixed issue raised in ticket #22979 [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #29932:
URL: https://github.com/apache/superset/pull/29932#discussion_r1721547610
##########
.vscode/settings.json:
##########
@@ -0,0 +1,5 @@
+{
Review Comment:
This change isn't probably related to the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org