[GitHub] [lucene] pawel-bugalski-dynatrace opened a new pull request #99: LUCENE-9869 allow for configuring a custom cache purge scheduler in Monitor (aka Luwak)

[GitBox <gi...@apache.org>]

pawel-bugalski-dynatrace opened a new pull request #99:
URL: https://github.com/apache/lucene/pull/99


   
   
   # Description
   
   By default org.apache.lucene.monitor.Monitor will create a new thread per instance
   in order to schedule its cache purge periodic task. This is not always the desired
   behaviour as for example one could create a large number of Monitor instances in a
   single JVM to separate business domains. In such case it would be counterproductive
   to create a new thread for each instance of Monitor. Instead through introduction
   of PurgeScheduler interface one can now implement its own scheduling strategy.
   
   # Solution
   
   Please provide a short description of the approach taken to implement your solution.
   
   # Tests
   
   Used this new API in an external codebase to confirm its proper behaviour and usefulness.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [x] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] pawel-bugalski-dynatrace commented on pull request #99: LUCENE-9869 allow for configuring a custom cache purge scheduler in Monitor (aka Luwak)

[GitBox <gi...@apache.org>]

pawel-bugalski-dynatrace commented on pull request #99:
URL: https://github.com/apache/lucene/pull/99#issuecomment-872958780


   @romseygeek @uschindler can you have a look at this PR. Do you think it is a move in a right direction? How can I improve it so it can be merged? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org