You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/11 17:40:29 UTC

[GitHub] [spark] bersprockets commented on pull request #37825: [SPARK-40382][SQL] Group distinct aggregate expressions by semantically equivalent children in `RewriteDistinctAggregates`

bersprockets commented on PR #37825:
URL: https://github.com/apache/spark/pull/37825#issuecomment-1243010034

   > #34953 take a look this pr?
   
   If I understand that PR correctly (and I may not), it is related but orthogonal. One PR doesn't preclude the other.
   
   The PR you reference is making the `Expand` projections narrower (by reusing slots that have the same data type) and including the `then` expression of if-like  expressions in the grouping of distinct aggregates -- thus potentially reducing the number of projections. I think that PR would still apply to the code even after my propose changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org