You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "niknegi (via GitHub)" <gi...@apache.org> on 2026/02/14 12:59:04 UTC
[PR] Added Default Implementations for Missing Types [fluss-rust]
niknegi opened a new pull request, #326:
URL: https://github.com/apache/fluss-rust/pull/326
<!--
*Thank you very much for contributing to Fluss - we are happy that you want to help us improve Fluss. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub issue](https://github.com/apache/fluss-rust/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull request", where *[component]* should be replaced by the name of the component being changed. Typically, this corresponds to the component label assigned to the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
- Each pull request should address only one issue, not mix up code from multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: https://github.com/apache/fluss-rust/issues/325
<!-- What is the purpose of the change -->
### Brief change log
Added Default implementation for CharType, DecimalType, BinaryType, ArrayType and MapType
### Tests
<img width="744" height="327" alt="Screenshot 2026-02-14 at 6 28 16 PM" src="https://github.com/user-attachments/assets/197f3bee-33e2-4e94-adf3-c7cd29d8d72f" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added Default Implementations for Missing Types [fluss-rust]
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia merged PR #326:
URL: https://github.com/apache/fluss-rust/pull/326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added Default Implementations for Missing Types [fluss-rust]
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on code in PR #326:
URL: https://github.com/apache/fluss-rust/pull/326#discussion_r2808222770
##########
crates/fluss/src/metadata/datatype.rs:
##########
@@ -838,6 +857,12 @@ impl ArrayType {
}
}
+impl Default for ArrayType {
Review Comment:
we shouldn't have default for array type
##########
crates/fluss/src/metadata/datatype.rs:
##########
@@ -885,6 +910,15 @@ impl MapType {
}
}
+impl Default for MapType {
+ fn default() -> Self {
Review Comment:
we shouldn't have default for array type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added Default Implementations for Missing Types [fluss-rust]
Posted by "niknegi (via GitHub)" <gi...@apache.org>.
niknegi commented on code in PR #326:
URL: https://github.com/apache/fluss-rust/pull/326#discussion_r2809093614
##########
crates/fluss/src/metadata/datatype.rs:
##########
@@ -838,6 +857,12 @@ impl ArrayType {
}
}
+impl Default for ArrayType {
Review Comment:
Removed
##########
crates/fluss/src/metadata/datatype.rs:
##########
@@ -885,6 +910,15 @@ impl MapType {
}
}
+impl Default for MapType {
+ fn default() -> Self {
Review Comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org