[collections] Changing Iterators

[Stephen Colebourne <sc...@btopenworld.com>]

I would like to make some changes to some of the Iterators in the
subpackage. In particular to make them consistent.

A number of the classes work on a list of iterators, but they provide
different constructors, validation and methods. I intend to tidy this up.

The changes may change the public interface (minor), but its a new package
so backwards compatability isn't required.

Stephen


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: [collections] Changing Iterators

[Stephen Colebourne <sc...@btopenworld.com>]

Now that the changes are made, I can explain them ;-)

CollatingIterator
- Constructors were added for array and Collection (no impact)
- addIterator now validates for nulls (no impact on valid code)
- add setIterator (no impact)
- add getIterators (no impact)

IteratorChain
- Constructors were added for array and Collection (no impact)
- List constructor removed (use Collection constructor)
- addIterator now validates for nulls (no impact on valid code)
- setIterator now validates for nulls (no impact on valid code)
- add getIterators (no impact)

ListIteratorWrapper
- constructor now validates for nulls (no impact on valid code)

Thus, if code ran before it should still do so. Does this need documenting ?

Stephen

----- Original Message -----
From: "Michael A. Smith" <ma...@apache.org>
To: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
Sent: Saturday, August 17, 2002 1:28 PM
Subject: Re: [collections] Changing Iterators


> Stephen Colebourne wrote:
> > I would like to make some changes to some of the Iterators in the
> > subpackage. In particular to make them consistent.
> >
> > A number of the classes work on a list of iterators, but they provide
> > different constructors, validation and methods. I intend to tidy this
up.
> >
> > The changes may change the public interface (minor), but its a new
package
> > so backwards compatability isn't required.
>
> But since some of the classes are just relocated from the previous
> release, backwards compatibility is still at least partially required.
> The interface changes should not reduce the functionality set or
> otherwise make it difficult for a user of the old collections release to
> migrate to the new collections release.  In other words, document any
> changes that are required for someone to use the new classes that has
> previously used the old ones (other than the package change, of course).
>
> regards,
> michael
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: [collections] Changing Iterators

["Michael A. Smith" <ma...@apache.org>]

Stephen Colebourne wrote:
> I would like to make some changes to some of the Iterators in the
> subpackage. In particular to make them consistent.
> 
> A number of the classes work on a list of iterators, but they provide
> different constructors, validation and methods. I intend to tidy this up.
> 
> The changes may change the public interface (minor), but its a new package
> so backwards compatability isn't required.

But since some of the classes are just relocated from the previous 
release, backwards compatibility is still at least partially required. 
The interface changes should not reduce the functionality set or 
otherwise make it difficult for a user of the old collections release to 
migrate to the new collections release.  In other words, document any 
changes that are required for someone to use the new classes that has 
previously used the old ones (other than the package change, of course).

regards,
michael


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>