You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/03/26 13:16:06 UTC

[GitHub] [cordova-plugin-device] timbru31 opened a new pull request #122: WIP: refactor(eslint): use cordova-eslint 

timbru31 opened a new pull request #122: WIP: refactor(eslint): use cordova-eslint 
URL: https://github.com/apache/cordova-plugin-device/pull/122
 
 
   Ref https://github.com/apache/cordova/issues/142
   Ref https://github.com/apache/cordova/issues/4
   
   Depends on #120, therefor WIP
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   
   
   ### Description
   <!-- Describe your changes in detail -->
   
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org

[GitHub] [cordova-plugin-device] timbru31 commented on a change in pull request #122: WIP: refactor(eslint): use cordova-eslint

Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #122: WIP: refactor(eslint): use cordova-eslint 
URL: https://github.com/apache/cordova-plugin-device/pull/122#discussion_r398611469
 
 

 ##########
 File path: tests/.eslintrc.yml
 ##########
 @@ -0,0 +1,2 @@
+root: true
 
 Review comment:
   LICENSE header is missing

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org

[GitHub] [cordova-plugin-device] timbru31 merged pull request #122: refactor(eslint): use cordova-eslint

Posted by GitBox <gi...@apache.org>.
timbru31 merged pull request #122: refactor(eslint): use cordova-eslint 
URL: https://github.com/apache/cordova-plugin-device/pull/122
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org

[GitHub] [cordova-plugin-device] erisu commented on issue #122: WIP: refactor(eslint): use cordova-eslint

Posted by GitBox <gi...@apache.org>.
erisu commented on issue #122: WIP: refactor(eslint): use cordova-eslint 
URL: https://github.com/apache/cordova-plugin-device/pull/122#issuecomment-604465186
 
 
   I see that there are two `.eslintrc.yml` files.
   
   - `<root>/.eslintrc.yml`
   - `<root>/tests/.eslintrc.yml`
   
   You can consolidate them into one file.
   
   - `<root>/.eslintrc.yml`
   
   ```yml
   # Licensed to the Apache Software Foundation (ASF) under one
   # or more contributor license agreements.  See the NOTICE file
   # distributed with this work for additional information
   # regarding copyright ownership.  The ASF licenses this file
   # to you under the Apache License, Version 2.0 (the
   # "License"); you may not use this file except in compliance
   # with the License.  You may obtain a copy of the License at
   #
   #   http://www.apache.org/licenses/LICENSE-2.0
   #
   # Unless required by applicable law or agreed to in writing,
   # software distributed under the License is distributed on an
   # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   # KIND, either express or implied.  See the License for the
   # specific language governing permissions and limitations
   # under the License.
   
   root: true
   extends: '@cordova/eslint-config/browser'
   
   overrides:
     - files: [tests/**/*.js]
       extends: '@cordova/eslint-config/node-tests'
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org

[GitHub] [cordova-plugin-device] timbru31 commented on a change in pull request #122: WIP: refactor(eslint): use cordova-eslint

Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #122: WIP: refactor(eslint): use cordova-eslint 
URL: https://github.com/apache/cordova-plugin-device/pull/122#discussion_r398611308
 
 

 ##########
 File path: .eslintrc.yml
 ##########
 @@ -1,10 +1,2 @@
 root: true
-extends: semistandard
-rules:
-  indent:
-    - error
-    - 4
-  camelcase: off
-  padded-blocks: off
-  operator-linebreak: off
-  no-throw-literal: off
\ No newline at end of file
+extends: "@cordova/eslint-config/browser"
 
 Review comment:
   LICENSE header is missing

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org