[GitHub] [pulsar] eolivelli commented on a diff in pull request #15955: PIP-174: New managed ledger entry cache implementation

[GitBox <gi...@apache.org>]

eolivelli commented on code in PR #15955:
URL: https://github.com/apache/pulsar/pull/15955#discussion_r949025813


##########
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/EntryCacheManagerTest.java:
##########
@@ -43,15 +43,26 @@
 import org.apache.bookkeeper.mledger.impl.cache.EntryCache;
 import org.apache.bookkeeper.mledger.impl.cache.EntryCacheDisabled;
 import org.apache.bookkeeper.mledger.impl.cache.EntryCacheManager;
+import org.apache.bookkeeper.mledger.impl.cache.RangeEntryCacheManagerImpl;
+import org.apache.bookkeeper.mledger.impl.cache.SharedEntryCacheManagerImpl;
 import org.apache.bookkeeper.test.MockedBookKeeperTestCase;
 import org.testng.Assert;
+import org.testng.annotations.DataProvider;
 import org.testng.annotations.Test;
 
 public class EntryCacheManagerTest extends MockedBookKeeperTestCase {
 
     ManagedLedgerImpl ml1;
     ManagedLedgerImpl ml2;
 
+    @DataProvider(name = "EntryCacheManagerClass")
+    public static Object[][] primeNumbers() {

Review Comment:
   nit: primeNumbers ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org