You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/12/03 06:13:30 UTC
[GitHub] [incubator-echarts] ztytotoro opened a new issue #13743: [echarts-gl] Undisposed zrender instance
ztytotoro opened a new issue #13743:
URL: https://github.com/apache/incubator-echarts/issues/13743
### Version
5.0.0
### Steps to reproduce
in [`echarts-gl\src\util\ZRTextureAtlasSurface.js(193)`](https://github.com/ecomfe/echarts-gl/blob/7cc547c903ac0f091b5736c19c15561bd0f21090/src/util/ZRTextureAtlasSurface.js#L193)
This line will create a zrender instance but cannot be disposed
### What is expected?
zrender instance should be disposed
### What is actually happening?
zrender instance cannot be disposed
<!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
<!-- This issue is in English. DO NOT REMOVE -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] ztytotoro commented on issue #13743: [echarts-gl] Undisposed zrender instance
Posted by GitBox <gi...@apache.org>.
ztytotoro commented on issue #13743:
URL: https://github.com/apache/incubator-echarts/issues/13743#issuecomment-738696053
Sorry, I read the code, `chart.getZr()` will return the zr instance create by [here](https://github.com/apache/incubator-echarts/blob/88bf43cb849e13cc6ee8d6ffd6811efdb3dc09a7/src/echarts.ts#L397)
but [echarts-gl\src\util\ZRTextureAtlasSurface.js(193)](https://github.com/ecomfe/echarts-gl/blob/7cc547c903ac0f091b5736c19c15561bd0f21090/src/util/ZRTextureAtlasSurface.js#L193) will call `zrender.init` to create a new zr instance
so when I call `chart.dispose()`, only `chart._zr` wiil be disposed.
e.g. the bar3D will [create a labelsBuilder](https://github.com/ecomfe/echarts-gl/blob/7cc547c903ac0f091b5736c19c15561bd0f21090/src/chart/bar3D/Bar3DView.js#L22), and the labelsBuilder create a [ZRTextureAtlasSurface](https://github.com/ecomfe/echarts-gl/blob/7cc547c903ac0f091b5736c19c15561bd0f21090/src/component/common/LabelsBuilder.js#L13), the ZRTextureAtlasSurface create a zr instance, however, when chart is disposed, Bar3DView will not dispose labelsBuilder
I didn't read all the code, maybe I missed something, but I did solved my problem when I added the missing dispose methods
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13743: [echarts-gl] Undisposed zrender instance
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #13743:
URL: https://github.com/apache/incubator-echarts/issues/13743#issuecomment-737690321
Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.
In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer.
If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical question.
If you are interested in the project, you may also subscribe our [mailing list](https://echarts.apache.org/en/maillist.html).
Have a nice day! 🍵
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on issue #13743: [echarts-gl] Undisposed zrender instance
Posted by GitBox <gi...@apache.org>.
Ovilia commented on issue #13743:
URL: https://github.com/apache/incubator-echarts/issues/13743#issuecomment-738606441
The zr instance can be accessed with `chart.getZr()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org