You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/04 16:08:20 UTC
[GitHub] [cloudstack-primate] ravening opened a new pull request #844: Show display text instead of name
ravening opened a new pull request #844:
URL: https://github.com/apache/cloudstack-primate/pull/844
While creating networks, for network offerings, show meaningful display text
instead of short names which is not much descriptive
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd edited a comment on pull request #844: Show display text instead of name
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #844:
URL: https://github.com/apache/cloudstack-primate/pull/844#issuecomment-722220193
@ravening we may need to build consensus then, we largely want Primate 1.0/GA to be backwards compatible wrt UX, so changing how a field is displayed may break several people's env who were used to seeing the name. (To satisfy everyone - one solution could be showing the name and in parenthesis the displayname).
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] ravening commented on pull request #844: Show display text instead of name
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #844:
URL: https://github.com/apache/cloudstack-primate/pull/844#issuecomment-721942578
> LGTM, but we need to check how legacy UI shows the name (name vs displayname vs description)
@rhtyd legacy ui displays name but it wont make sense just by looking at the name. `displaytext` gives more info about the offering
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #844: Show display text instead of name
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #844:
URL: https://github.com/apache/cloudstack-primate/pull/844#issuecomment-722220823
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #844: Show display text instead of name
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #844:
URL: https://github.com/apache/cloudstack-primate/pull/844#discussion_r546650210
##########
File path: src/views/network/CreateIsolatedNetworkForm.vue
##########
@@ -125,7 +125,7 @@
:placeholder="this.$t('label.networkofferingid')"
@change="val => { this.handleNetworkOfferingChange(this.networkOfferings[val]) }">
<a-select-option v-for="(opt, optIndex) in this.networkOfferings" :key="optIndex">
- {{ opt.name || opt.description }}
+ {{ opt.displaytext || opt.description }}
</a-select-option>
Review comment:
@ravening can this be: `opt.displaytext | opt.name | ...` to cover for the case if/when displaytext is empty?
##########
File path: src/views/network/CreateL2NetworkForm.vue
##########
@@ -125,7 +125,7 @@
:placeholder="this.$t('label.networkofferingid')"
@change="val => { this.handleNetworkOfferingChange(this.networkOfferings[val]) }">
<a-select-option v-for="(opt, optIndex) in this.networkOfferings" :key="optIndex">
- {{ opt.name || opt.description }}
+ {{ opt.displaytext || opt.description }}
Review comment:
@ravening can this be: `opt.displaytext | opt.name | ...` to cover for the case if/when displaytext is empty?
##########
File path: src/views/network/CreateSharedNetworkForm.vue
##########
@@ -284,7 +284,7 @@
:placeholder="this.$t('label.networkofferingid')"
@change="val => { this.handleNetworkOfferingChange(this.networkOfferings[val]) }">
<a-select-option v-for="(opt, optIndex) in this.networkOfferings" :key="optIndex">
- {{ opt.name || opt.description }}
+ {{ opt.displaytext || opt.description }}
Review comment:
@ravening can this be: `opt.displaytext | opt.name | ...` to cover for the case if/when displaytext is empty?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #844: Show display text instead of name
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #844:
URL: https://github.com/apache/cloudstack-primate/pull/844#issuecomment-748921246
cc @davidjumani
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #844: Show display text instead of name
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #844:
URL: https://github.com/apache/cloudstack-primate/pull/844#issuecomment-722221253
For now, moved to 1.1 as this is not a blocker or critical issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #844: Show display text instead of name
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #844:
URL: https://github.com/apache/cloudstack-primate/pull/844#issuecomment-722226569
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/844 (JID-3644)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #844: Show display text instead of name
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #844:
URL: https://github.com/apache/cloudstack-primate/pull/844#issuecomment-722220193
@ravening we may need to build concensus then, we largely want Primate 1.0/GA to be backwards compatible wrt UX, so changing how a field is displayed may break several people's env who were used to seeing the name. (To satisfy everyone - one solution could be showing the name and in parenthesis the displayname).
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org