[GitHub] merlimat commented on a change in pull request #2508: PIP-22: Dead Letter Topic

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #2508: PIP-22: Dead Letter Topic
URL: https://github.com/apache/incubator-pulsar/pull/2508#discussion_r216536479
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
 ##########
 @@ -1184,6 +1239,40 @@ public void redeliverUnacknowledgedMessages(Set<MessageId> messageIds) {
             MessageIdData.Builder builder = MessageIdData.newBuilder();
             batches.forEach(ids -> {
                 List<MessageIdData> messageIdDatas = ids.stream().map(messageId -> {
+                    List<MessageImpl<T>> deadLetterMessages = null;
 
 Review comment:
   Can this new portion of code be factored out in a separate method that is called from here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services