You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/14 14:34:22 UTC

[GitHub] [airflow] bbovenzi commented on a diff in pull request #27639: Enable copying DagRun JSON to clipboard

bbovenzi commented on code in PR #27639:
URL: https://github.com/apache/airflow/pull/27639#discussion_r1021614293


##########
airflow/www/static/js/dag/details/dagRun/index.tsx:
##########
@@ -78,6 +80,7 @@ const DagRun = ({ runId }: Props) => {
     execution_date: executionDate,
   }).toString();
   const graphLink = appendSearchParams(graphUrl, graphParams);
+  const { onCopy, hasCopied } = useClipboard(conf);

Review Comment:
   We'll want to have the `useClipboard` hook before `if (!run) return null;`
   
   Also, since run or conf could be null. Let's change it to `useClipboard(run?.conf || '')`
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org