[GitHub] rob05c removed a comment on issue #3002: Add TM GC CPU fraction to stat endpoint

[GitBox <gi...@apache.org>]

rob05c removed a comment on issue #3002: Add TM GC CPU fraction to stat endpoint
URL: https://github.com/apache/trafficcontrol/pull/3002#issuecomment-439514675
 
 
   I'm not sure what a test for this would even look like? It's adding a single field to a struct. What is there to test?
   
   I guess we could test that the variable assignment works? But it seems like we can trust the language at least that far.
   
   At the high level, an Integration Test for the `/publish/Stats` endpoint would be good. But the Monitor doesn't currently have an Integration Test Framework, it'd take weeks if not months to write one. Are we going to require that, for this tiny PR just to add one debug stat to the endpoint? I agree, that'd be great to have. But it seems like a lot, to require months of work, for a single field PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services