You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/01/29 14:01:47 UTC

[GitHub] [singa] joddiy opened a new issue #583: The padding of Conv2d and Pool22 not support SAME_UPPER, SAME_LOWER

joddiy opened a new issue #583: The padding of Conv2d and Pool22 not support SAME_UPPER, SAME_LOWER
URL: https://github.com/apache/singa/issues/583
 
 
   Now the singa's padding is, we assign a value, and it adds the amount of value's padding at both sides of head and tail.
   
   However, according to the [onnx doc](https://github.com/onnx/onnx/blob/master/docs/Operators.md#Conv), there are four types of padding method, which are NOTSET, SAME_UPPER, SAME_LOWER or VALID. Singa cannot support SAME_UPPER, SAME_LOWER yet.
   
   > SAME_UPPER or SAME_LOWER mean pad the input so that the output spatial size match the input. In case of an odd number add the extra padding at the end for SAME_UPPER and at the beginning for SAME_LOWER.
   
   For example, the input is 32*32, the stride is 1, the kernel is 4*4, and output is same, we need to add (3,3) zeros totally, each side is 3/2 = 1.5, cannot work base on the current setting of singa.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [singa] nudles commented on issue #583: The padding of Conv2d and Pool22 not support SAME_UPPER, SAME_LOWER

Posted by GitBox <gi...@apache.org>.
nudles commented on issue #583: The padding of Conv2d and Pool22 not support SAME_UPPER, SAME_LOWER
URL: https://github.com/apache/singa/issues/583#issuecomment-596174224
 
 
   @joddiy Has the issues been fixed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [singa] joddiy closed issue #583: The padding of Conv2d and Pool22 not support SAME_UPPER, SAME_LOWER

Posted by GitBox <gi...@apache.org>.
joddiy closed issue #583: The padding of Conv2d and Pool22 not support SAME_UPPER, SAME_LOWER
URL: https://github.com/apache/singa/issues/583
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [singa] joddiy commented on issue #583: The padding of Conv2d and Pool22 not support SAME_UPPER, SAME_LOWER

Posted by GitBox <gi...@apache.org>.
joddiy commented on issue #583: The padding of Conv2d and Pool22 not support SAME_UPPER, SAME_LOWER
URL: https://github.com/apache/singa/issues/583#issuecomment-596201365
 
 
   yes, by PR #612 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services