You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/17 02:39:29 UTC
[GitHub] [skywalking] mrproliu opened a new pull request #4528: Fix profile
trace not match when change the entry operationId/Name
mrproliu opened a new pull request #4528: Fix profile trace not match when change the entry operationId/Name
URL: https://github.com/apache/skywalking/pull/4528
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
___
### Bug fix
- Profile trace does not match with dynamic change the name, such as `SpringMVC`. I put the recheck profile in the wrong place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4528:
Fix profile trace not match when change the entry operationId/Name
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4528: Fix profile trace not match when change the entry operationId/Name
URL: https://github.com/apache/skywalking/pull/4528#discussion_r393425250
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/TracingContext.java
##########
@@ -353,6 +353,12 @@ public AbstractSpan createEntrySpan(final String operationName) {
final AbstractSpan parentSpan = peek();
final int parentSpanId = parentSpan == null ? -1 : parentSpan.getSpanId();
if (parentSpan != null && parentSpan.isEntry()) {
+ /**
+ * Only add the profiling recheck on change entry span operationId/Name.
+ * Because Change name only happen on entry span.
+ * Exit and local span will check need profiling on construct the context.
+ */
Review comment:
Already reword this comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4528: Fix profile trace not match when change the entry operationId/Name
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4528: Fix profile trace not match when change the entry operationId/Name
URL: https://github.com/apache/skywalking/pull/4528#discussion_r393424811
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/TracingContext.java
##########
@@ -353,6 +353,12 @@ public AbstractSpan createEntrySpan(final String operationName) {
final AbstractSpan parentSpan = peek();
final int parentSpanId = parentSpan == null ? -1 : parentSpan.getSpanId();
if (parentSpan != null && parentSpan.isEntry()) {
+ /**
+ * Only add the profiling recheck on change entry span operationId/Name.
+ * Because Change name only happen on entry span.
+ * Exit and local span will check need profiling on construct the context.
+ */
Review comment:
```suggestion
/*
* Only add the profiling recheck when changing an entry span's operationId/Name.
* Because changing name only happens on entry span.
* Exit and local span will check when constructing the context.
*/
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4528: Fix profile trace
not match when change the entry operationId/Name
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4528: Fix profile trace not match when change the entry operationId/Name
URL: https://github.com/apache/skywalking/pull/4528#issuecomment-599857673
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4528?src=pr&el=h1) Report
> Merging [#4528](https://codecov.io/gh/apache/skywalking/pull/4528?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/dcd66ee6e940bdc9a7ecf90415929bfd48a3a284&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4528?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4528 +/- ##
==========================================
- Coverage 25.56% 25.53% -0.03%
==========================================
Files 1244 1244
Lines 28951 28951
Branches 3968 3968
==========================================
- Hits 7400 7393 -7
- Misses 20867 20874 +7
Partials 684 684
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4528?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4528/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `60.36% <ø> (-0.36%)` | :arrow_down: |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/4528/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `61.27% <100.00%> (+0.16%)` | :arrow_up: |
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4528/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4528?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4528?src=pr&el=footer). Last update [dcd66ee...cca54b0](https://codecov.io/gh/apache/skywalking/pull/4528?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4528: Fix profile trace
not match when change the entry operationId/Name
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4528: Fix profile trace not match when change the entry operationId/Name
URL: https://github.com/apache/skywalking/pull/4528
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4528: Fix
profile trace not match when change the entry operationId/Name
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4528: Fix profile trace not match when change the entry operationId/Name
URL: https://github.com/apache/skywalking/pull/4528#issuecomment-599857673
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4528?src=pr&el=h1) Report
> Merging [#4528](https://codecov.io/gh/apache/skywalking/pull/4528?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/dcd66ee6e940bdc9a7ecf90415929bfd48a3a284&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4528?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4528 +/- ##
==========================================
- Coverage 25.56% 25.53% -0.03%
==========================================
Files 1244 1244
Lines 28951 28951
Branches 3968 3968
==========================================
- Hits 7400 7393 -7
- Misses 20867 20874 +7
Partials 684 684
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4528?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4528/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `60.36% <ø> (-0.36%)` | :arrow_down: |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/4528/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `61.27% <100.00%> (+0.16%)` | :arrow_up: |
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4528/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4528?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4528?src=pr&el=footer). Last update [dcd66ee...cca54b0](https://codecov.io/gh/apache/skywalking/pull/4528?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services