You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by Neil Bliss <ne...@neilbliss.com> on 2010/04/30 21:46:02 UTC
HADOOP-6704 - getResource() usage ok?
Hey folks,
In the unit tests for my HADOOP-6704 patch, I'm using getResource() to get
the URL of a sample xml file. On my local system this works fine, but when
I submitted the patch to Hudson, it appears to not find the resource file.
Is this sort of thing not allowed in the Hudson environment, or am I just
doing something wrong?
I've already fixed up the checkstyle errors that I missed the first time
around. Gomen nasai.
thanks,
Neil
Re: HADOOP-6704 - getResource() usage ok?
Posted by Eli Collins <el...@cloudera.com>.
Nope, just "submit patch" if you haven't done so already, Huson will
pick it up and run the tests. When you upload a new patch and you've
already submitted a patch you need to "cancel patch" then "submit
patch" again to get Hudson to run again.
Thanks,
Eli
On Fri, Apr 30, 2010 at 4:24 PM, Neil Bliss <ne...@gmail.com> wrote:
> (sorry for being a pest, but...)
>
> Now that I've put the new patch on there, do I need to do anything special
> to have the "submit patch" feature do the right thing?
>
> thanks again,
>
> Neil
>
> On Fri, Apr 30, 2010 at 3:56 PM, Owen O'Malley <ow...@gmail.com>wrote:
>
>> On Fri, Apr 30, 2010 at 3:45 PM, Neil Bliss <ne...@gmail.com> wrote:
>> > For subsequent patch submissions, should I first remove the earlier patch
>> > from the Jira, or just attach the newer revision?
>>
>> Just attach the newer version. It sometimes helps to see the history
>> of a patch as it grows.
>>
>
Re: HADOOP-6704 - getResource() usage ok?
Posted by Neil Bliss <ne...@gmail.com>.
(sorry for being a pest, but...)
Now that I've put the new patch on there, do I need to do anything special
to have the "submit patch" feature do the right thing?
thanks again,
Neil
On Fri, Apr 30, 2010 at 3:56 PM, Owen O'Malley <ow...@gmail.com>wrote:
> On Fri, Apr 30, 2010 at 3:45 PM, Neil Bliss <ne...@gmail.com> wrote:
> > For subsequent patch submissions, should I first remove the earlier patch
> > from the Jira, or just attach the newer revision?
>
> Just attach the newer version. It sometimes helps to see the history
> of a patch as it grows.
>
Re: HADOOP-6704 - getResource() usage ok?
Posted by Owen O'Malley <ow...@gmail.com>.
On Fri, Apr 30, 2010 at 3:45 PM, Neil Bliss <ne...@gmail.com> wrote:
> For subsequent patch submissions, should I first remove the earlier patch
> from the Jira, or just attach the newer revision?
Just attach the newer version. It sometimes helps to see the history
of a patch as it grows.
Re: HADOOP-6704 - getResource() usage ok?
Posted by Eli Collins <el...@cloudera.com>.
Just attach a the newer version. You can see the most recent patch
based on the date however most people just append a number
(hadoop-6704-2.patch etc) to indicate the patch is newer.
Thanks,
Eli
On Fri, Apr 30, 2010 at 3:45 PM, Neil Bliss <ne...@gmail.com> wrote:
> For subsequent patch submissions, should I first remove the earlier patch
> from the Jira, or just attach the newer revision?
>
> thanks,
>
> Neil
>
> On Fri, Apr 30, 2010 at 3:40 PM, Neil Bliss <ne...@gmail.com> wrote:
>
>> Found the problem, I had an overly helpful local CLASSPATH set.
>>
>>
>> On Fri, Apr 30, 2010 at 1:22 PM, Neil Bliss <ne...@gmail.com> wrote:
>>
>>> Thanks Eli, I'll have a look how the other instances are used, and see if
>>> I can spot the problem.
>>>
>>> - Neil
>>>
>>>
>>> On Fri, Apr 30, 2010 at 1:17 PM, Eli Collins <el...@cloudera.com> wrote:
>>>
>>>> Hey Neil,
>>>>
>>>> There are other uses of getResource in Hadoop so should be fine.
>>>> Should you be using getClassLoader#getResource() instead of
>>>> Class#getResource()?
>>>>
>>>> Thanks,
>>>> Eli
>>>>
>>>> On Fri, Apr 30, 2010 at 12:46 PM, Neil Bliss <ne...@neilbliss.com> wrote:
>>>> > Hey folks,
>>>> >
>>>> > In the unit tests for my HADOOP-6704 patch, I'm using getResource() to
>>>> get
>>>> > the URL of a sample xml file. On my local system this works fine, but
>>>> when
>>>> > I submitted the patch to Hudson, it appears to not find the resource
>>>> file.
>>>> > Is this sort of thing not allowed in the Hudson environment, or am I
>>>> just
>>>> > doing something wrong?
>>>> >
>>>> > I've already fixed up the checkstyle errors that I missed the first
>>>> time
>>>> > around. Gomen nasai.
>>>> >
>>>> > thanks,
>>>> >
>>>> > Neil
>>>> >
>>>>
>>>
>>>
>>
>
Re: HADOOP-6704 - getResource() usage ok?
Posted by Neil Bliss <ne...@gmail.com>.
For subsequent patch submissions, should I first remove the earlier patch
from the Jira, or just attach the newer revision?
thanks,
Neil
On Fri, Apr 30, 2010 at 3:40 PM, Neil Bliss <ne...@gmail.com> wrote:
> Found the problem, I had an overly helpful local CLASSPATH set.
>
>
> On Fri, Apr 30, 2010 at 1:22 PM, Neil Bliss <ne...@gmail.com> wrote:
>
>> Thanks Eli, I'll have a look how the other instances are used, and see if
>> I can spot the problem.
>>
>> - Neil
>>
>>
>> On Fri, Apr 30, 2010 at 1:17 PM, Eli Collins <el...@cloudera.com> wrote:
>>
>>> Hey Neil,
>>>
>>> There are other uses of getResource in Hadoop so should be fine.
>>> Should you be using getClassLoader#getResource() instead of
>>> Class#getResource()?
>>>
>>> Thanks,
>>> Eli
>>>
>>> On Fri, Apr 30, 2010 at 12:46 PM, Neil Bliss <ne...@neilbliss.com> wrote:
>>> > Hey folks,
>>> >
>>> > In the unit tests for my HADOOP-6704 patch, I'm using getResource() to
>>> get
>>> > the URL of a sample xml file. On my local system this works fine, but
>>> when
>>> > I submitted the patch to Hudson, it appears to not find the resource
>>> file.
>>> > Is this sort of thing not allowed in the Hudson environment, or am I
>>> just
>>> > doing something wrong?
>>> >
>>> > I've already fixed up the checkstyle errors that I missed the first
>>> time
>>> > around. Gomen nasai.
>>> >
>>> > thanks,
>>> >
>>> > Neil
>>> >
>>>
>>
>>
>
Re: HADOOP-6704 - getResource() usage ok?
Posted by Neil Bliss <ne...@gmail.com>.
Found the problem, I had an overly helpful local CLASSPATH set.
On Fri, Apr 30, 2010 at 1:22 PM, Neil Bliss <ne...@gmail.com> wrote:
> Thanks Eli, I'll have a look how the other instances are used, and see if I
> can spot the problem.
>
> - Neil
>
>
> On Fri, Apr 30, 2010 at 1:17 PM, Eli Collins <el...@cloudera.com> wrote:
>
>> Hey Neil,
>>
>> There are other uses of getResource in Hadoop so should be fine.
>> Should you be using getClassLoader#getResource() instead of
>> Class#getResource()?
>>
>> Thanks,
>> Eli
>>
>> On Fri, Apr 30, 2010 at 12:46 PM, Neil Bliss <ne...@neilbliss.com> wrote:
>> > Hey folks,
>> >
>> > In the unit tests for my HADOOP-6704 patch, I'm using getResource() to
>> get
>> > the URL of a sample xml file. On my local system this works fine, but
>> when
>> > I submitted the patch to Hudson, it appears to not find the resource
>> file.
>> > Is this sort of thing not allowed in the Hudson environment, or am I
>> just
>> > doing something wrong?
>> >
>> > I've already fixed up the checkstyle errors that I missed the first time
>> > around. Gomen nasai.
>> >
>> > thanks,
>> >
>> > Neil
>> >
>>
>
>
Re: HADOOP-6704 - getResource() usage ok?
Posted by Neil Bliss <ne...@gmail.com>.
Thanks Eli, I'll have a look how the other instances are used, and see if I
can spot the problem.
- Neil
On Fri, Apr 30, 2010 at 1:17 PM, Eli Collins <el...@cloudera.com> wrote:
> Hey Neil,
>
> There are other uses of getResource in Hadoop so should be fine.
> Should you be using getClassLoader#getResource() instead of
> Class#getResource()?
>
> Thanks,
> Eli
>
> On Fri, Apr 30, 2010 at 12:46 PM, Neil Bliss <ne...@neilbliss.com> wrote:
> > Hey folks,
> >
> > In the unit tests for my HADOOP-6704 patch, I'm using getResource() to
> get
> > the URL of a sample xml file. On my local system this works fine, but
> when
> > I submitted the patch to Hudson, it appears to not find the resource
> file.
> > Is this sort of thing not allowed in the Hudson environment, or am I
> just
> > doing something wrong?
> >
> > I've already fixed up the checkstyle errors that I missed the first time
> > around. Gomen nasai.
> >
> > thanks,
> >
> > Neil
> >
>
Re: HADOOP-6704 - getResource() usage ok?
Posted by Eli Collins <el...@cloudera.com>.
Hey Neil,
There are other uses of getResource in Hadoop so should be fine.
Should you be using getClassLoader#getResource() instead of
Class#getResource()?
Thanks,
Eli
On Fri, Apr 30, 2010 at 12:46 PM, Neil Bliss <ne...@neilbliss.com> wrote:
> Hey folks,
>
> In the unit tests for my HADOOP-6704 patch, I'm using getResource() to get
> the URL of a sample xml file. On my local system this works fine, but when
> I submitted the patch to Hudson, it appears to not find the resource file.
> Is this sort of thing not allowed in the Hudson environment, or am I just
> doing something wrong?
>
> I've already fixed up the checkstyle errors that I missed the first time
> around. Gomen nasai.
>
> thanks,
>
> Neil
>