You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/10 16:39:23 UTC

[GitHub] [kafka] jolshan commented on a change in pull request #10584: KAFKA-12701: NPE in MetadataRequest when using topic IDs

jolshan commented on a change in pull request #10584:
URL: https://github.com/apache/kafka/pull/10584#discussion_r649352099



##########
File path: core/src/test/scala/unit/kafka/server/MetadataRequestTest.scala
##########
@@ -234,6 +235,32 @@ class MetadataRequestTest extends AbstractMetadataRequestTest {
     }
   }
 
+  @Test
+  def testInvalidMetadataRequestReturnsError(): Unit = {

Review comment:
       This was one way to test the KafkaApis code, but I suppose I could move this to a unit test that only tests the method itself (and not the whole request path)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org