You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/30 20:23:15 UTC

[GitHub] [incubator-tvm] tqchen opened a new issue #6179: [TESTS][FLAKY] tests/python/relay/test_op_grad_level2.py: verify_conv2d_grad

tqchen opened a new issue #6179:
URL: https://github.com/apache/incubator-tvm/issues/6179


   https://ci.tvm.ai/blue/organizations/jenkins/tvm/detail/PR-6173/3/pipeline
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] areusch commented on issue #6179: [TESTS][FLAKY] tests/python/relay/test_op_grad_level2.py: verify_conv2d_grad

Posted by GitBox <gi...@apache.org>.
areusch commented on issue #6179:
URL: https://github.com/apache/incubator-tvm/issues/6179#issuecomment-667302952


   I bisected this by building with ci-gpu and running `tests/python/relay/test_op_grad_level2.py` 10 times, I believe the offending PR is #5758 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] tqchen commented on issue #6179: [TESTS][FLAKY] tests/python/relay/test_op_grad_level2.py: verify_conv2d_grad

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #6179:
URL: https://github.com/apache/incubator-tvm/issues/6179#issuecomment-666769790


   cc @jroesch @MarisaKirisame @junrushao1994 @antinucleon 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] tqchen edited a comment on issue #6179: Fix conv2d grad for strided cases under the new conv2d_transpose def

Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #6179:
URL: https://github.com/apache/incubator-tvm/issues/6179#issuecomment-667404934


   In particular, it seems that we will need to fix the [conv2d grad](https://github.com/vinx13/tvm/blob/master/python/tvm/relay/op/_tensor_grad.py#L339) def under the new spec of conv2d_transpose introduced in #5758. Thanks @areusch for finding the offending PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] tqchen commented on issue #6179: [TESTS][FLAKY] tests/python/relay/test_op_grad_level2.py: verify_conv2d_grad

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #6179:
URL: https://github.com/apache/incubator-tvm/issues/6179#issuecomment-666670447


   An additional note is that we should change the grad verification to use numerical grad checking instead of Pytorch


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] tqchen commented on issue #6179: Fix conv2d grad for strided cases under the new conv2d_transpose def

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #6179:
URL: https://github.com/apache/incubator-tvm/issues/6179#issuecomment-668176799


   NOTE, the test is temporarily disabled in https://github.com/apache/incubator-tvm/pull/6183, we will update this issue again once @vinx13 fix the problem


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] vinx13 commented on issue #6179: Fix conv2d grad for strided cases under the new conv2d_transpose def

Posted by GitBox <gi...@apache.org>.
vinx13 commented on issue #6179:
URL: https://github.com/apache/incubator-tvm/issues/6179#issuecomment-667405460


   I will take a look


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] tqchen commented on issue #6179: Fix conv2d grad for strided cases under the new conv2d_transpose def

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #6179:
URL: https://github.com/apache/incubator-tvm/issues/6179#issuecomment-667404934


   In particular, it seems that we will need to fix the conv2d grad def under the new spec of conv2d_transpose introduced in #5758. Thanks @areusch for finding the offending PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] tqchen closed issue #6179: Fix conv2d grad for strided cases under the new conv2d_transpose def

Posted by GitBox <gi...@apache.org>.
tqchen closed issue #6179:
URL: https://github.com/apache/incubator-tvm/issues/6179


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] tqchen commented on issue #6179: [TESTS][FLAKY] tests/python/relay/test_op_grad_level2.py: verify_conv2d_grad

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #6179:
URL: https://github.com/apache/incubator-tvm/issues/6179#issuecomment-667401953


    @vinx13  it would be great if you can followup on this thread


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org