You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by majetideepak <gi...@git.apache.org> on 2017/08/10 14:53:41 UTC
[GitHub] orc pull request #152: ORC-227: [C++] Fix docker failure due to ExternalProj...
GitHub user majetideepak opened a pull request:
https://github.com/apache/orc/pull/152
ORC-227: [C++] Fix docker failure due to ExternalProject_Add and sign mismatch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/majetideepak/orc ORC-227
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #152
----
commit 00e27b78127f3a0e8e5faba9f60f8429a287d19b
Author: Deepak Majeti <de...@hpe.com>
Date: 2017-08-10T14:37:32Z
Fix ExternalProject_Add
commit c49122d9687ce9551ca462560d307710f2751223
Author: Deepak Majeti <de...@hpe.com>
Date: 2017-08-10T14:42:42Z
Fix signed and unsigned mismatch
commit c80d021c3c64f0f180f16f13e72d2abbc82c13db
Author: Deepak Majeti <de...@hpe.com>
Date: 2017-08-10T14:47:05Z
Fix signed and unsigned mismatch
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #152: ORC-227: [C++] Fix docker failure due to ExternalProj...
Posted by xndai <gi...@git.apache.org>.
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/152#discussion_r132531200
--- Diff: c++/src/ByteRLE.cc ---
@@ -26,9 +26,9 @@
namespace orc {
- const size_t MINIMUM_REPEAT = 3;
- const size_t MAXIMUM_REPEAT = 127 + MINIMUM_REPEAT;
- const size_t MAX_LITERAL_SIZE = 128;
+ const int MINIMUM_REPEAT = 3;
+ const int MAXIMUM_REPEAT = 127 + MINIMUM_REPEAT;
+ const int MAX_LITERAL_SIZE = 128;
--- End diff --
ok. Thanks for fixing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #152: ORC-227: [C++] Fix docker failure due to ExternalProj...
Posted by majetideepak <gi...@git.apache.org>.
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/152#discussion_r132529457
--- Diff: c++/src/ByteRLE.cc ---
@@ -26,9 +26,9 @@
namespace orc {
- const size_t MINIMUM_REPEAT = 3;
- const size_t MAXIMUM_REPEAT = 127 + MINIMUM_REPEAT;
- const size_t MAX_LITERAL_SIZE = 128;
+ const int MINIMUM_REPEAT = 3;
+ const int MAXIMUM_REPEAT = 127 + MINIMUM_REPEAT;
+ const int MAX_LITERAL_SIZE = 128;
--- End diff --
I tried CentOS6 docker image. The warnings seem to be correct.
```
cc1plus: warnings being treated as errors
/root/orc/c++/src/ByteRLE.cc: In member function ‘void orc::ByteRleEncoderImpl::write(char)’:
/root/orc/c++/src/ByteRLE.cc:152: error: comparison between signed and unsigned integer expressions
/root/orc/c++/src/ByteRLE.cc:166: error: comparison between signed and unsigned integer expressions
/root/orc/c++/src/ByteRLE.cc:167: error: comparison between signed and unsigned integer expressions
/root/orc/c++/src/ByteRLE.cc:179: error: comparison between signed and unsigned integer expressions
make[2]: *** [c++/src/CMakeFiles/orc.dir/ByteRLE.cc.o] Error 1
make[1]: *** [c++/src/CMakeFiles/orc.dir/all] Error 2
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #152: ORC-227: [C++] Fix docker failure due to ExternalProj...
Posted by majetideepak <gi...@git.apache.org>.
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/152#discussion_r132477368
--- Diff: c++/src/ByteRLE.cc ---
@@ -26,9 +26,9 @@
namespace orc {
- const size_t MINIMUM_REPEAT = 3;
- const size_t MAXIMUM_REPEAT = 127 + MINIMUM_REPEAT;
- const size_t MAX_LITERAL_SIZE = 128;
+ const int MINIMUM_REPEAT = 3;
+ const int MAXIMUM_REPEAT = 127 + MINIMUM_REPEAT;
+ const int MAX_LITERAL_SIZE = 128;
--- End diff --
@xndai @wgtmac These changes are required to avoid signed and unsigned mismatch warnings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #152: ORC-227: [C++] Fix docker failure due to ExternalProj...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/orc/pull/152
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #152: ORC-227: [C++] Fix docker failure due to ExternalProj...
Posted by xndai <gi...@git.apache.org>.
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/152#discussion_r132522783
--- Diff: c++/src/ByteRLE.cc ---
@@ -26,9 +26,9 @@
namespace orc {
- const size_t MINIMUM_REPEAT = 3;
- const size_t MAXIMUM_REPEAT = 127 + MINIMUM_REPEAT;
- const size_t MAX_LITERAL_SIZE = 128;
+ const int MINIMUM_REPEAT = 3;
+ const int MAXIMUM_REPEAT = 127 + MINIMUM_REPEAT;
+ const int MAX_LITERAL_SIZE = 128;
--- End diff --
I don't see the mismatch warnings on CentOS7 docker image. Where did you see that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---