You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/25 03:34:47 UTC

[GitHub] [shardingsphere] lanchengx opened a new issue #16359: [OpenForce 2022] Add more unit test for `AlterInstanceHandler`

lanchengx opened a new issue #16359:
URL: https://github.com/apache/shardingsphere/issues/16359


   Hi community,
   
   This issue is for https://github.com/apache/shardingsphere/discussions/12683#discussioncomment-2139441
   
   We need to add more unit tests for AlterInstanceHandler to cover the thrown exception
   
   - [ ] AlterInstanceHandler
   
   Example FYI
   - AlterTrafficRuleHandlerTest
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ismailalammar edited a comment on issue #16359: [OpenForce 2022] Add more unit test for `AlterInstanceHandler`

Posted by GitBox <gi...@apache.org>.
ismailalammar edited a comment on issue #16359:
URL: https://github.com/apache/shardingsphere/issues/16359#issuecomment-1079536655


   Hi @lanchengx  i would like contribute under OpenForce 2022 , could you please assign this issue to me? And also if possible suggestion on how to get started with this issue. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ismailalammar commented on issue #16359: [OpenForce 2022] Add more unit test for `AlterInstanceHandler`

Posted by GitBox <gi...@apache.org>.
ismailalammar commented on issue #16359:
URL: https://github.com/apache/shardingsphere/issues/16359#issuecomment-1079604867


   Hi @strongduanmu i've submitted a PR regarding this issue , kindly let me know if there is any issue.
   
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ismailalammar commented on issue #16359: [OpenForce 2022] Add more unit test for `AlterInstanceHandler`

Posted by GitBox <gi...@apache.org>.
ismailalammar commented on issue #16359:
URL: https://github.com/apache/shardingsphere/issues/16359#issuecomment-1079536655


   Hi @lanchengx  i would like to work on this issue , could you please assign this issue to me? And also if possible suggestion on how to get started with this issue. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu closed issue #16359: [OpenForce 2022] Add more unit test for `AlterInstanceHandler`

Posted by GitBox <gi...@apache.org>.
strongduanmu closed issue #16359:
URL: https://github.com/apache/shardingsphere/issues/16359


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on issue #16359: [OpenForce 2022] Add more unit test for `AlterInstanceHandler`

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #16359:
URL: https://github.com/apache/shardingsphere/issues/16359#issuecomment-1079555623


   @ismailalammar Welcome, you can refer AlterTrafficRuleHandlerTest, it give an good example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org