You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "whhe (via GitHub)" <gi...@apache.org> on 2023/07/27 13:18:40 UTC

[GitHub] [flink-connector-hbase] whhe opened a new pull request, #17: [FLINK-28013] Shade all netty dependencies in sql jar

whhe opened a new pull request, #17:
URL: https://github.com/apache/flink-connector-hbase/pull/17

   Shade all netty dependencies to resolve `java.lang.NoClassDefFoundError: org/apache/flink/hbase/shaded/io/netty/channel/EventLoopGroup`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-hbase] whhe commented on pull request #17: [FLINK-28013] Shade all netty dependencies in sql jar

Posted by "whhe (via GitHub)" <gi...@apache.org>.
whhe commented on PR #17:
URL: https://github.com/apache/flink-connector-hbase/pull/17#issuecomment-1659629496

   Any progress?  @MartijnVisser 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-hbase] boring-cyborg[bot] commented on pull request #17: [FLINK-28013] Shade all netty dependencies in sql jar

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #17:
URL: https://github.com/apache/flink-connector-hbase/pull/17#issuecomment-1653614729

   Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-hbase] MartijnVisser merged pull request #17: [FLINK-28013] Shade all netty dependencies in sql jar

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser merged PR #17:
URL: https://github.com/apache/flink-connector-hbase/pull/17


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-hbase] whhe commented on pull request #17: [FLINK-28013] Shade all netty dependencies in sql jar

Posted by "whhe (via GitHub)" <gi...@apache.org>.
whhe commented on PR #17:
URL: https://github.com/apache/flink-connector-hbase/pull/17#issuecomment-1655247084

   > @whhe The connector actually shouldn't rely on `flink-shaded` at all.
   
   It will not depend on 'flink-shaded', this modification is to add netty packages other than 'netty-all', such as 'netty-transport' here, to the sql jar.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-hbase] MartijnVisser commented on pull request #17: [FLINK-28013] Shade all netty dependencies in sql jar

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #17:
URL: https://github.com/apache/flink-connector-hbase/pull/17#issuecomment-1655299963

   > this modification is to add netty packages other than 'netty-all', such as 'netty-transport' here, to the sql jar.
   
   Ah sorry, I misread. I'll try to have a look later today


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-hbase] YesOrNo828 commented on pull request #17: [FLINK-28013] Shade all netty dependencies in sql jar

Posted by "YesOrNo828 (via GitHub)" <gi...@apache.org>.
YesOrNo828 commented on PR #17:
URL: https://github.com/apache/flink-connector-hbase/pull/17#issuecomment-1661865824

   I tested this patch locally which resolves this NoClassDefFoundError exception;
   ```java.lang.NoClassDefFoundError: org/apache/flink/hbase/shaded/io/netty/channel/EventLoopGroup.```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-hbase] whhe commented on pull request #17: [FLINK-28013] Shade all netty dependencies in sql jar

Posted by "whhe (via GitHub)" <gi...@apache.org>.
whhe commented on PR #17:
URL: https://github.com/apache/flink-connector-hbase/pull/17#issuecomment-1694945023

   Hello again @MartijnVisser, please take a look on this pr if you are available. It wouldn't take a long time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-hbase] boring-cyborg[bot] commented on pull request #17: [FLINK-28013] Shade all netty dependencies in sql jar

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #17:
URL: https://github.com/apache/flink-connector-hbase/pull/17#issuecomment-1695587144

   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-hbase] whhe commented on pull request #17: [FLINK-28013] Shade all netty dependencies in sql jar

Posted by "whhe (via GitHub)" <gi...@apache.org>.
whhe commented on PR #17:
URL: https://github.com/apache/flink-connector-hbase/pull/17#issuecomment-1654957332

   @MartijnVisser PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org