You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/15 03:48:31 UTC
[GitHub] [shardingsphere] strongduanmu opened a new issue, #19189: Consider to add @ToString annotation for SQLStatement and SQLSegment
strongduanmu opened a new issue, #19189:
URL: https://github.com/apache/shardingsphere/issues/19189
## Feature Request
### Is your feature request related to a problem?
No.
### Describe the feature you would like.
According to the code conduct, each `SQLStatement` and `SQLSegment` implementation class must add the lombok `@ToString` annotation. If the implementation class inherits a parent class, you need to add the `callSuper = true` parameter.
At present, there are many SQLStatements and SQLSegments in the SQL Parser module without the `@ToString` annotation, which leads to the fact that when `sql-show` printing is enabled, only the address of the object can be printed, not the content of the object.
Therefore, we need to add `@ToString` annotations to SQLStatement and SQLSegment of different databases according to the specification.
- [ ] Add `@ToString` annotation for common SQLStatement and SQLSegment
- [ ] Add `@ToString` annotation for MySQL SQLStatement and SQLSegment
- [ ] Add `@ToString` annotation for PostgreSQL SQLStatement and SQLSegment
- [ ] Add `@ToString` annotation for openGauss SQLStatement and SQLSegment
- [ ] Add `@ToString` annotation for SQLServer SQLStatement and SQLSegment
- [ ] Add `@ToString` annotation for Oracle SQLStatement and SQLSegment
- [ ] Add `@ToString` annotation for SQL92 SQLStatement and SQLSegment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #19189: Consider to add @ToString annotation for SQLStatement and SQLSegment
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #19189:
URL: https://github.com/apache/shardingsphere/issues/19189#issuecomment-1188533445
@chakkk309 @Trydamere Thank you for your contribution. Since all subtasks has been finished, I will close this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu closed issue #19189: Consider to add @ToString annotation for SQLStatement and SQLSegment
Posted by GitBox <gi...@apache.org>.
strongduanmu closed issue #19189: Consider to add @ToString annotation for SQLStatement and SQLSegment
URL: https://github.com/apache/shardingsphere/issues/19189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #19189: Consider to add @ToString annotation for SQLStatement and SQLSegment
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #19189:
URL: https://github.com/apache/shardingsphere/issues/19189#issuecomment-1185397873
@Trydamere Of course, You can communicate with @chakkk309 about issue assignment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Trydamere commented on issue #19189: Consider to add @ToString annotation for SQLStatement and SQLSegment
Posted by GitBox <gi...@apache.org>.
Trydamere commented on issue #19189:
URL: https://github.com/apache/shardingsphere/issues/19189#issuecomment-1185395735
Can I work on several tasks? @strongduanmu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Trydamere commented on issue #19189: Consider to add @ToString annotation for SQLStatement and SQLSegment
Posted by GitBox <gi...@apache.org>.
Trydamere commented on issue #19189:
URL: https://github.com/apache/shardingsphere/issues/19189#issuecomment-1185416278
Hi @chakkk309, I will work on Oracle and SQL92 SQLStatement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #19189: Consider to add @ToString annotation for SQLStatement and SQLSegment
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #19189:
URL: https://github.com/apache/shardingsphere/issues/19189#issuecomment-1185165362
@chakkk309 Welcome, you can refer #19191 to finish other tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] chakkk309 commented on issue #19189: Consider to add @ToString annotation for SQLStatement and SQLSegment
Posted by GitBox <gi...@apache.org>.
chakkk309 commented on issue #19189:
URL: https://github.com/apache/shardingsphere/issues/19189#issuecomment-1185164924
Hi, I want to try it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] chakkk309 commented on issue #19189: Consider to add @ToString annotation for SQLStatement and SQLSegment
Posted by GitBox <gi...@apache.org>.
chakkk309 commented on issue #19189:
URL: https://github.com/apache/shardingsphere/issues/19189#issuecomment-1185412959
Hi @Trydamere, I'm working on PostgreSQL, openGauss and SQLServer SQLStatement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org